Skip to content

visualizer framework fix#2014

Merged
drosetti merged 5 commits intodevelopfrom
visualizer-framework-update
Dec 7, 2023
Merged

visualizer framework fix#2014
drosetti merged 5 commits intodevelopfrom
visualizer-framework-update

Conversation

@drosetti
Copy link
Contributor

@drosetti drosetti commented Dec 6, 2023 •
edited
Loading

Description

Fix in the visualizer framework.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. [Doc]("How to create a Plugin")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Merging #2014 (f71ae64) into develop (aa8820f) will increase coverage by 8.93%.
Report is 1554 commits behind head on develop.
The diff coverage is 75.46%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2014      +/-   ##
===========================================
+ Coverage    66.75%   75.68%   +8.93%     
===========================================
  Files           95      464     +369     
  Lines         3706    13824   +10118     
  Branches       519     1431     +912     
===========================================
+ Hits          2474    10463    +7989     
- Misses         941     2800    +1859     
- Partials       291      561     +270
Files Coverage Δ
api_app/analyzers_manager/admin.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/apps.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/constants.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/exceptions.py 100.00% <100.00%> (ø)
...app/analyzers_manager/file_analyzers/boxjs_scan.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/onenote.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/peframe.py 82.35% <100.00%> (ø)
...i_app/analyzers_manager/file_analyzers/rtf_info.py 48.64% <100.00%> (ø)
...s_manager/file_analyzers/xlm_macro_deobfuscator.py 62.50% <100.00%> (ø)
api_app/analyzers_manager/filters.py 100.00% <100.00%> (ø)
... and 236 more

... and 274 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96f180...f71ae64. Read the comment docs.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
api_app/views.py Outdated
except NotImplementedError as e:
logger.info(f"NotImplementedError {e}, user {request.user}, name {pk}")
raise ValidationError({"detail": "Not implemented"})
raise ValidationError({"detail": str(e)})

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
@drosetti drosetti merged commit 4bdc711 into develop Dec 7, 2023
@drosetti drosetti deleted the visualizer-framework-update branch December 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@drosetti