Skip to content

Frontend fixes#2003

Merged
drosetti merged 33 commits intodevelopfrom
frontend_fixes_2
Nov 30, 2023
Merged

Frontend fixes#2003
drosetti merged 33 commits intodevelopfrom
frontend_fixes_2

Conversation

@carellamartina
Copy link
Contributor

@carellamartina carellamartina commented Nov 29, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. [Doc]("How to create a Plugin")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

carellamartina and others added 28 commits November 23, 2023 14:56
@carellamartina
adjusted analyzers info + promote/remove admin
9a48132
@carellamartina
fix tests
0a0c0ea
@mlodic @carellamartina
updated readme
4ec3f52
@mlodic @carellamartina
optimized memory in remove_old_jobs fun
d8a3383
@0ssigeno @carellamartina
Fix tags with playbook
ac8373b 
Signed-off-by: 0ssigeno <[email protected]>
@0ssigeno @carellamartina
Fix error on 2mega + files
4f9fd42 
Signed-off-by: 0ssigeno <[email protected]>
@mlodic @carellamartina
fixed Pivot Visualizer
8f69ffe
@0ssigeno @carellamartina
Fix link
54cb9ba 
Signed-off-by: 0ssigeno <[email protected]>
@0ssigeno @carellamartina
Fix tags
bd86e83 
Signed-off-by: 0ssigeno <[email protected]>
@0ssigeno @carellamartina
Revert tags
55881ee 
Signed-off-by: 0ssigeno <[email protected]>
@drosetti @carellamartina
update frontend dependencies
5441920
@mlodic @carellamartina
added catching of DNS request timeout error
6178395
@mlodic @carellamartina
adjusted last commit
b8ef389
@mlodic @carellamartina
fix memory issues for file analysis
cda3161
@dependabot @mlodic
@0ssigeno @code-review-doctor @drosetti @abheektripathy @AshirRashid @0xquark @hyprsyd @Parthmadan-1 @shivam-Purohit @ben-ce @kyletaylored @0x0elliot @deepsource-autofix @carellamartina
Bump django from 4.1.10 to 4.1.13 in /requirements (#1979)
ec8557c 
Bumps [django](https://github.com/django/django) from 4.1.10 to 4.1.13.
- [Commits](django/django@4.1.10...4.1.13)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: 0ssigeno <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: 0ssigeno <[email protected]>
Co-authored-by: Matteo Lodi <[email protected]>
Co-authored-by: Simone Berni <[email protected]>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: drosetti <[email protected]>
Co-authored-by: Abheek Tripathy <[email protected]>
Co-authored-by: AshirRashid <[email protected]>
Co-authored-by: Karanjot Singh <[email protected]>
Co-authored-by: 0ssigeno <[email protected]>
Co-authored-by: Daniele Rosetti <[email protected]>
Co-authored-by: Siddhanth <[email protected]>
Co-authored-by: Parth Madan <[email protected]>
Co-authored-by: Shivam Purohit <[email protected]>
Co-authored-by: shivam <[email protected]>
Co-authored-by: Martina Carella <[email protected]>
Co-authored-by: ben-ce <[email protected]>
Co-authored-by: Kyle Taylor <[email protected]>
Co-authored-by: Aditya <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@dependabot @carellamartina
Bump maxminddb from 2.4.0 to 2.5.1 in /requirements (#1988)
446e398 
Bumps [maxminddb](https://github.com/maxmind/MaxMind-DB-Reader-python) from 2.4.0 to 2.5.1.
- [Release notes](https://github.com/maxmind/MaxMind-DB-Reader-python/releases)
- [Changelog](https://github.com/maxmind/MaxMind-DB-Reader-python/blob/main/HISTORY.rst)
- [Commits](maxmind/MaxMind-DB-Reader-python@v2.4.0...v2.5.1)

---
updated-dependencies:
- dependency-name: maxminddb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mlodic @carellamartina
bump dnspython
0edeaba
@drosetti @carellamartina
fix certego-ui dependency
962253f
@mlodic @carellamartina
Revert "fix memory issues for file analysis"
b1508f9 
This reverts commit af0b016.
@mlodic @carellamartina
incremented DATA_UPLOAD_MAX_MEMORY_SIZE
21953e9
@mlodic @carellamartina
incremented FILE_UPLOAD_MAX_MEMORY_SIZE
79ca3d2
@0ssigeno @carellamartina
Fix for change on frontend structure
3fffe78 
Signed-off-by: 0ssigeno <[email protected]>
@drosetti @carellamartina
fix file analysis
55e3a4c
@mlodic @carellamartina
fix memory issues for file analysis
c8cec62
@mlodic @carellamartina
reverting adjustment to MultiplePlaybooksMultipleFileAnalysisSerializer
8b70999
@drosetti @carellamartina
tooltips in the visualizer elements are available even if the element…
41417e8 
…s are disabled
@carellamartina
fixes
a795ec1
@carellamartina
bump certego-saas
5fe7a4f
code-review-doctor[bot]
code-review-doctor bot suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Worth considering though. View full project report here.

api_app/analyzers_manager/observable_analyzers/dns/dns_resolvers/classic_dns_resolver.py
except socket.timeout:
message = (
f"request for {self.observable_name} for classic"
f" DNS triggered timeout"
Copy link
Contributor

@code-review-doctor code-review-doctor bot Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f" DNS triggered timeout"
" DNS triggered timeout"

f-string is unnecessary here. This can just be a string. Read more.

@codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #2003 (b218407) into develop (aa8820f) will increase coverage by 8.83%.
Report is 1527 commits behind head on develop.
The diff coverage is 75.39%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2003      +/-   ##
===========================================
+ Coverage    66.75%   75.58%   +8.83%     
===========================================
  Files           95      446     +351     
  Lines         3706    13662    +9956     
  Branches       519     1423     +904     
===========================================
+ Hits          2474    10327    +7853     
- Misses         941     2773    +1832     
- Partials       291      562     +271
Files Coverage Δ
api_app/analyzers_manager/admin.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/apps.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/constants.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/exceptions.py 100.00% <100.00%> (ø)
...app/analyzers_manager/file_analyzers/boxjs_scan.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/onenote.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/peframe.py 82.35% <100.00%> (ø)
...i_app/analyzers_manager/file_analyzers/rtf_info.py 48.64% <100.00%> (ø)
...s_manager/file_analyzers/xlm_macro_deobfuscator.py 62.50% <100.00%> (ø)
api_app/analyzers_manager/filters.py 100.00% <100.00%> (ø)
... and 235 more

... and 256 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25f7b2...b218407. Read the comment docs.

drosetti
drosetti requested changes Nov 30, 2023
View reviewed changes
@drosetti drosetti merged commit ecfef21 into develop Nov 30, 2023
@drosetti drosetti deleted the frontend_fixes_2 branch November 30, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drosetti drosetti drosetti approved these changes

+1 more reviewer

@code-review-doctor code-review-doctor[bot] code-review-doctor[bot] requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carellamartina @drosetti @mlodic @0ssigeno