Skip to content

enable/disable playbook for org#1965

Merged
drosetti merged 7 commits intodevelopfrom
org_playbook
Oct 26, 2023
Merged

enable/disable playbook for org#1965
drosetti merged 7 commits intodevelopfrom
org_playbook

Conversation

@carellamartina
Copy link
Contributor

@carellamartina carellamartina commented Oct 25, 2023

Description

Owner/admin can enable/disable custom playbook for the org

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook or ingestor) was added or changed, in which case:
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #1965 (36b4b31) into develop (46d5774) will increase coverage by 0.19%.
Report is 19 commits behind head on develop.
The diff coverage is 75.00%.

❗ Current head 36b4b31 differs from pull request most recent head 12cd1b5. Consider uploading reports for the commit 12cd1b5 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
+ Coverage    75.81%   76.01%   +0.19%     
===========================================
  Files          441      447       +6     
  Lines        13559    13705     +146     
  Branches      1418     1435      +17     
===========================================
+ Hits         10280    10418     +138     
  Misses        2712     2712              
- Partials       567      575       +8
Files Coverage Δ
api_app/serializers.py 86.28% <100.00%> (-0.01%) ⬇️
api_app/views.py 84.45% <0.00%> (-0.22%) ⬇️

... and 26 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d5774...12cd1b5. Read the comment docs.

drosetti
drosetti requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@drosetti drosetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Just some changes:

  • See DeepSource suggestion
  • I think in case we do a rebase we can avoid the double check in the frontend because owner is also and admin
  • There is a little bug in the plugins -> playbook section: in case via Django admin a playbook is marked as disable for the org, but the "disabled" flag is not checked, the playbook is show as active with the green icon for the org memebers, I suggest to make it disactive as for the disabled playbook. In the start scan the playbook disabled for the orgs are correctly filtered.

@drosetti drosetti merged commit 90903fd into develop Oct 26, 2023
@drosetti drosetti deleted the org_playbook branch October 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drosetti drosetti drosetti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carellamartina @drosetti