Skip to content

Fixed error timeout error in the capesandbox analyzer#1964

Merged
0ssigeno merged 18 commits intodevelopfrom
timeout-capesandbox-analyzer
Oct 25, 2023
Merged

Fixed error timeout error in the capesandbox analyzer#1964
0ssigeno merged 18 commits intodevelopfrom
timeout-capesandbox-analyzer

Conversation

@federicofantini
Copy link
Contributor

Description

added timeout on every request of capesandbox analyzer + start the poll for result after the analysis is ended

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook or ingestor) was added or changed, in which case:
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1964 (fabb30a) into develop (2713452) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1964      +/-   ##
===========================================
- Coverage    76.06%   76.03%   -0.04%     
===========================================
  Files          446      446              
  Lines        13684    13684              
  Branches      1434     1434              
===========================================
- Hits         10409    10404       -5     
- Misses        2702     2705       +3     
- Partials       573      575       +2     
Files Coverage Δ
...p/analyzers_manager/file_analyzers/cape_sandbox.py 62.23% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2713452...fabb30a. Read the comment docs.

@0ssigeno 0ssigeno merged commit bb0362e into develop Oct 25, 2023
@0ssigeno 0ssigeno deleted the timeout-capesandbox-analyzer branch October 25, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants