Conversation
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| logger.info( | ||
| f"Job: {self.job_id} ->" | ||
| f"Sleeping for the entire duration of the analysis: {self.timeout}s" | ||
| ) | ||
| time.sleep(self.timeout) |
There was a problem hiding this comment.
Is it possible for cape to end the analysis before timeout ? If it is not possible, cool, this works; if it is, this will wait the maximum time possible in any case
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
0ssigeno
left a comment
0ssigeno
left a comment
There was a problem hiding this comment.
lgtm, just fix the migration file (you just need to change the number and its dependency to the latest in develop)
Codecov Report
@@ Coverage Diff @@
## develop #1947 +/- ##
===========================================
+ Coverage 75.68% 76.03% +0.34%
===========================================
Files 438 446 +8
Lines 13442 13684 +242
Branches 1406 1434 +28
===========================================
+ Hits 10174 10404 +230
- Misses 2704 2705 +1
- Partials 564 575 +11
... and 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2 participants
Description
added timeout on every request of capesandbox analyzer + start the poll for result after the analysis is ended
Type of change
Checklist
develop_monkeypatch()was used in its class to apply the necessary decorators.test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook inplaybook_config.json.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.