Skip to content

fixed default scan param load playbook#1836

Merged
drosetti merged 1 commit intodevelopfrom
fix-scan-param
Aug 9, 2023
Merged

fixed default scan param load playbook#1836
drosetti merged 1 commit intodevelopfrom
fix-scan-param

Conversation

@drosetti
Copy link
Contributor

@drosetti drosetti commented Aug 9, 2023

Description

Fix to the default scan param

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook or ingestor) was added or changed, in which case:
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@drosetti drosetti requested a review from mlodic August 9, 2023 14:59
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1836 (c2a6794) into develop (aa8820f) will increase coverage by 9.44%.
Report is 1275 commits behind head on develop.
The diff coverage is 76.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1836      +/-   ##
===========================================
+ Coverage    66.75%   76.20%   +9.44%     
===========================================
  Files           95      378     +283     
  Lines         3706    12385    +8679     
  Branches       519     1304     +785     
===========================================
+ Hits          2474     9438    +6964     
- Misses         941     2409    +1468     
- Partials       291      538     +247     
Files Changed Coverage Δ
...analyzers_manager/migrations/0004_datamigration.py 91.30% <ø> (ø)
api_app/connectors_manager/views.py 100.00% <ø> (ø)
api_app/decorators.py 78.94% <ø> (ø)
api_app/defaults.py 100.00% <ø> (ø)
api_app/documents.py 100.00% <ø> (ø)
api_app/fields.py 57.14% <ø> (ø)
api_app/filters.py 72.97% <ø> (ø)
api_app/forms.py 37.50% <ø> (ø)
api_app/helpers.py 65.90% <ø> (+5.90%) ⬆️
api_app/ingestors_manager/admin.py 100.00% <ø> (ø)
... and 231 more

... and 190 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1148e8b...c2a6794. Read the comment docs.

@drosetti drosetti merged commit c5b0902 into develop Aug 9, 2023
@drosetti drosetti deleted the fix-scan-param branch August 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants