Conversation
…r_organization enabled
Codecov Report
@@ Coverage Diff @@
## develop #1827 +/- ##
===========================================
+ Coverage 76.20% 76.21% +0.01%
===========================================
Files 378 378
Lines 12380 12383 +3
Branches 1303 1303
===========================================
+ Hits 9434 9438 +4
+ Misses 2408 2407 -1
Partials 538 538
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0ssigeno
approved these changes
Aug 8, 2023
0ssigeno
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plugin-config
for_organizationdoesn't support multiple lines because client side they are converted to spaces.Added code to revert to a valid certificate format.
Type of change
Checklist
develop_monkeypatch()was used in its class to apply the necessary decorators.test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook inplaybook_config.json.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.