Skip to content

fixed multiline strings in capesandbox analyzer with plugin-config for_organization enabled#1827

Merged
0ssigeno merged 3 commits intodevelopfrom
capesandbox-analyzer-fix
Aug 8, 2023
Merged

fixed multiline strings in capesandbox analyzer with plugin-config for_organization enabled#1827
0ssigeno merged 3 commits intodevelopfrom
capesandbox-analyzer-fix

Conversation

@federicofantini
Copy link
Contributor

Description

Plugin-config for_organization doesn't support multiple lines because client side they are converted to spaces.
Added code to revert to a valid certificate format.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • X] The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook or ingestor) was added or changed, in which case:
    • Usage file was updated.
    • [X Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1827 (76b579c) into develop (77977ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1827      +/-   ##
===========================================
+ Coverage    76.20%   76.21%   +0.01%     
===========================================
  Files          378      378              
  Lines        12380    12383       +3     
  Branches      1303     1303              
===========================================
+ Hits          9434     9438       +4     
+ Misses        2408     2407       -1     
  Partials       538      538              
Files Changed Coverage Δ
...p/analyzers_manager/file_analyzers/cape_sandbox.py 63.56% <100.00%> (+0.86%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77977ed...76b579c. Read the comment docs.

@0ssigeno 0ssigeno merged commit 44b4eca into develop Aug 8, 2023
@0ssigeno 0ssigeno deleted the capesandbox-analyzer-fix branch August 8, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants