Visualizer copy by carellamartina · Pull Request #1780 · intelowlproject/IntelOwl

carellamartina · 2023-07-05T14:02:46Z

Description

Added tooltip component with description, copy and link buttons on base and bool visualizer element.

Type of change

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

Important Rules

If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

* added function to handle visualizers errors * doc update

* More status mgmt Signed-off-by: 0ssigeno <[email protected]> * Black Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix migrations Signed-off-by: 0ssigeno <[email protected]> * Fix migrations Signed-off-by: 0ssigeno <[email protected]> * Prettier Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]>

* Start Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * Visualizer config points only to a single playbook, not many Signed-off-by: 0ssigeno <[email protected]> * Fix migration Signed-off-by: 0ssigeno <[email protected]> * Fix tests Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix post review Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * little adjustments * Blake Signed-off-by: 0ssigeno <[email protected]> * Unused migration Signed-off-by: 0ssigeno <[email protected]> * Fix page order Signed-off-by: 0ssigeno <[email protected]> * Fix migration Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: Matteo Lodi <[email protected]>

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@e38b190...08b4669) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 3.2.1 to 3.3.3. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v3.2.1...v3.3.3) --- updated-dependencies: - dependency-name: pre-commit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix captcha Signed-off-by: 0ssigeno <[email protected]> * Fix backend Signed-off-by: 0ssigeno <[email protected]> * fix frontend * Fix environments Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * black * Fix deepsource Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: Daniele Rosetti <[email protected]>

Signed-off-by: 0ssigeno <[email protected]>

* Pivot Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * Typo Signed-off-by: 0ssigeno <[email protected]> * Pivot Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Update tests/pivot_manager/test_views.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Update tests/pivot_manager/test_views.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Update api_app/pivots_manager/models.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Fix post review Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * More fixes and tests Signed-off-by: 0ssigeno <[email protected]> * More fixes Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * deepsource Signed-off-by: 0ssigeno <[email protected]> * typo * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Manage files Signed-off-by: 0ssigeno <[email protected]> * Fix test Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> Co-authored-by: Matteo Lodi <[email protected]>

* collapsed jobInfoCard in jobResult * adjusted UncontrolledTooltip message * added collapse test

Signed-off-by: 0ssigeno <[email protected]>

* fixed status * changed size for children elements * removed test * test modify * added small * improved small value * fixed frontend tests * prettier

Signed-off-by: 0ssigeno <[email protected]>

code-review-doctor

Some food for thought. View full project report here.

api_app/core/models.py

api_app/pivots_manager/models.py

api_app/visualizers_manager/models.py

codecov · 2023-07-05T16:30:45Z

Codecov Report

Merging #1780 (fcc6907) into develop (aa8820f) will increase coverage by 8.75%.
The diff coverage is 75.38%.

@@             Coverage Diff             @@
##           develop    #1780      +/-   ##
===========================================
+ Coverage    66.75%   75.50%   +8.75%     
===========================================
  Files           95      356     +261     
  Lines         3706    11755    +8049     
  Branches       519     1245     +726     
===========================================
+ Hits          2474     8876    +6402     
- Misses         941     2374    +1433     
- Partials       291      505     +214

Impacted Files	Coverage Δ
...analyzers_manager/migrations/0004_datamigration.py	`91.30% <ø> (ø)`
api_app/management/commands/dumpplugin.py	`0.00% <0.00%> (ø)`
api_app/management/commands/dumppluginconfig.py	`0.00% <0.00%> (ø)`
api_app/management/commands/update_analyzer.py	`0.00% <0.00%> (ø)`
api_app/migrations/0001_initial.py	`100.00% <ø> (ø)`
api_app/migrations/0002_added_job_field.py	`100.00% <ø> (ø)`
api_app/migrations/0003_auto_20201020_1406.py	`100.00% <ø> (ø)`
api_app/migrations/0004_auto_20201112_0021.py	`100.00% <ø> (ø)`
api_app/migrations/0005_auto_20210610_1028.py	`100.00% <ø> (ø)`
api_app/migrations/0006_v3_release.py	`100.00% <ø> (ø)`
... and 233 more

... and 166 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66806b...fcc6907. Read the comment docs.

frontend/src/components/jobs/result/visualizer/VisualizerTooltip.jsx

carellamartina and others added 21 commits June 27, 2023 18:28

added CopyToClipboardButton

18db188

adjusted copy_text field and visualizer tests

77ef18d

added function to handle visualizers errors (#1741)

7a6e717

* added function to handle visualizers errors * doc update

updated frontend dependencies

7e7e780

adjusted order in docs

f42d4b4

added link to HackinBo presentation

c3bb669

Fix waiting

77c7a54

Signed-off-by: 0ssigeno <[email protected]>

set USE_RECAPTCHA as False by default

2d88ce3

collapsed job metadata in job result (#1754)

1837024

* collapsed jobInfoCard in jobResult * adjusted UncontrolledTooltip message * added collapse test

Fix

00f3383

Signed-off-by: 0ssigeno <[email protected]>

Frontend improvements (#1772)

78e7a6b

* fixed status * changed size for children elements * removed test * test modify * added small * improved small value * fixed frontend tests * prettier

Fix migrations

ecee0e6

Signed-off-by: 0ssigeno <[email protected]>

added CopyToClipboardButton

b0b1583

adjusted copy_text field and visualizer tests

881c544

added VisualizerTooltip component + adjusted tests

a4a3b8a

code-review-doctor bot suggested changes Jul 5, 2023

View reviewed changes

Merge branch 'develop' into visualizer_copy

1445bcc

carellamartina requested a review from drosetti July 5, 2023 14:42

removed redundant default arguments

d13e75e

drosetti approved these changes Jul 5, 2023

View reviewed changes

frontend/src/components/jobs/result/visualizer/VisualizerTooltip.jsx Outdated Show resolved Hide resolved

carellamartina added 2 commits July 11, 2023 11:58

adjusted tooltip position + tests

0ff8e01

fix

470a650

carellamartina requested a review from drosetti July 11, 2023 10:04

drosetti requested changes Jul 14, 2023

View reviewed changes

frontend/src/components/jobs/result/visualizer/VisualizerTooltip.jsx Show resolved Hide resolved

carellamartina added 2 commits July 19, 2023 17:28

adjested buttons

e834cd9

fixed tests

fcc6907

drosetti approved these changes Jul 26, 2023

View reviewed changes

drosetti merged commit 357f7f1 into develop Jul 26, 2023

drosetti deleted the visualizer_copy branch July 26, 2023 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Visualizer copy#1780

Visualizer copy#1780
drosetti merged 27 commits intodevelopfrom
visualizer_copy

carellamartina commented Jul 5, 2023

Uh oh!

code-review-doctor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 5, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

carellamartina commented Jul 5, 2023

Description

Type of change

Checklist

Important Rules

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 5, 2023 •

edited

Loading