collapsed job metadata in job result by carellamartina · Pull Request #1754 · intelowlproject/IntelOwl

carellamartina · 2023-06-20T14:14:29Z

Description

collapsed job metadata in job result

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

Important Rules

If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

codecov · 2023-06-20T14:32:00Z

Codecov Report

Merging #1754 (967025f) into develop (aa8820f) will increase coverage by 7.88%.
The diff coverage is 75.23%.

❗ Current head 967025f differs from pull request most recent head b7f2f15. Consider uploading reports for the commit b7f2f15 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1754      +/-   ##
===========================================
+ Coverage    66.75%   74.64%   +7.88%     
===========================================
  Files           95      328     +233     
  Lines         3706    11239    +7533     
  Branches       519     1236     +717     
===========================================
+ Hits          2474     8389    +5915     
- Misses         941     2340    +1399     
- Partials       291      510     +219

Impacted Files	Coverage Δ
...analyzers_manager/migrations/0004_datamigration.py	`91.30% <ø> (ø)`
api_app/management/commands/dumpplugin.py	`0.00% <0.00%> (ø)`
api_app/management/commands/dumppluginconfig.py	`0.00% <0.00%> (ø)`
api_app/management/commands/update_analyzer.py	`0.00% <0.00%> (ø)`
api_app/migrations/0002_added_job_field.py	`100.00% <ø> (ø)`
api_app/migrations/0003_auto_20201020_1406.py	`100.00% <ø> (ø)`
api_app/migrations/0004_auto_20201112_0021.py	`100.00% <ø> (ø)`
api_app/migrations/0005_auto_20210610_1028.py	`100.00% <ø> (ø)`
api_app/migrations/0006_v3_release.py	`100.00% <ø> (ø)`
api_app/migrations/0007_alter_tag_color.py	`100.00% <ø> (ø)`
... and 233 more

... and 138 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a133a...b7f2f15. Read the comment docs.

mlodic · 2023-06-23T13:52:15Z

can you share a screenshot like you did the last time? in this way, we can review the GUI without having to build up the project ourselves! Thank you!

carellamartina · 2023-06-26T09:05:56Z

frontend/src/components/jobs/result/utils/sections.jsx

drosetti

Very good! I just request a change to the test: can you add a simple test where you simulate the user interaction ?

I suggest to to check the div with the info is "hidden" when the test start, then click the button and check is not hidden anymore. You can check the Collapse element is not hidden when it has the class "show"

* collapsed jobInfoCard in jobResult * adjusted UncontrolledTooltip message * added collapse test

* added CopyToClipboardButton * adjusted copy_text field and visualizer tests * added function to handle visualizers errors (#1741) * added function to handle visualizers errors * doc update * More status mgmt (#1740) * More status mgmt Signed-off-by: 0ssigeno <[email protected]> * Black Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix migrations Signed-off-by: 0ssigeno <[email protected]> * Fix migrations Signed-off-by: 0ssigeno <[email protected]> * Prettier Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> * updated frontend dependencies * Visualizer connected to playbook (#1755) * Start Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * Visualizer config points only to a single playbook, not many Signed-off-by: 0ssigeno <[email protected]> * Fix migration Signed-off-by: 0ssigeno <[email protected]> * Fix tests Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fix post review Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * little adjustments * Blake Signed-off-by: 0ssigeno <[email protected]> * Unused migration Signed-off-by: 0ssigeno <[email protected]> * Fix page order Signed-off-by: 0ssigeno <[email protected]> * Fix migration Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: Matteo Lodi <[email protected]> * adjusted order in docs * added link to HackinBo presentation * Bump ossf/scorecard-action from 2.1.2 to 2.2.0 (#1763) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@e38b190...08b4669) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pre-commit from 3.2.1 to 3.3.3 in /requirements (#1764) Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 3.2.1 to 3.3.3. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v3.2.1...v3.3.3) --- updated-dependencies: - dependency-name: pre-commit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix captcha (#1761) * Fix captcha Signed-off-by: 0ssigeno <[email protected]> * Fix backend Signed-off-by: 0ssigeno <[email protected]> * fix frontend * Fix environments Signed-off-by: 0ssigeno <[email protected]> * Fix Signed-off-by: 0ssigeno <[email protected]> * black * Fix deepsource Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: Daniele Rosetti <[email protected]> * Fix waiting Signed-off-by: 0ssigeno <[email protected]> * Pivot framework (#1739) * Pivot Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * More stuff Signed-off-by: 0ssigeno <[email protected]> * Typo Signed-off-by: 0ssigeno <[email protected]> * Pivot Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Update tests/pivot_manager/test_views.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Update tests/pivot_manager/test_views.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Update api_app/pivots_manager/models.py Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> * Fix post review Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * More fixes and tests Signed-off-by: 0ssigeno <[email protected]> * More fixes Signed-off-by: 0ssigeno <[email protected]> * Minor fixes Signed-off-by: 0ssigeno <[email protected]> * deepsource Signed-off-by: 0ssigeno <[email protected]> * typo * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Blake Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Fixes Signed-off-by: 0ssigeno <[email protected]> * Manage files Signed-off-by: 0ssigeno <[email protected]> * Fix test Signed-off-by: 0ssigeno <[email protected]> --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com> Co-authored-by: Matteo Lodi <[email protected]> * set USE_RECAPTCHA as False by default * collapsed job metadata in job result (#1754) * collapsed jobInfoCard in jobResult * adjusted UncontrolledTooltip message * added collapse test * Fix Signed-off-by: 0ssigeno <[email protected]> * Frontend improvements (#1772) * fixed status * changed size for children elements * removed test * test modify * added small * improved small value * fixed frontend tests * prettier * Fix migrations Signed-off-by: 0ssigeno <[email protected]> * added CopyToClipboardButton * adjusted copy_text field and visualizer tests * added VisualizerTooltip component + adjusted tests * removed redundant default arguments * adjusted tooltip position + tests * fix * adjested buttons * fixed tests --------- Signed-off-by: 0ssigeno <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Daniele Rosetti <[email protected]> Co-authored-by: Simone Berni <[email protected]> Co-authored-by: Daniele Rosetti <[email protected]> Co-authored-by: Matteo Lodi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 0ssigeno <[email protected]> Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>

collapsed jobInfoCard in jobResult

967025f

carellamartina requested a review from drosetti June 20, 2023 14:23

mlodic approved these changes Jun 26, 2023

View reviewed changes

frontend/src/components/jobs/result/utils/sections.jsx Outdated Show resolved Hide resolved

adjusted UncontrolledTooltip message

6ea4924

drosetti requested changes Jun 26, 2023

View reviewed changes

added collapse test

b7f2f15

carellamartina requested a review from drosetti June 28, 2023 08:27

drosetti approved these changes Jun 30, 2023

View reviewed changes

drosetti merged commit 19cc049 into develop Jun 30, 2023

drosetti deleted the job_result branch June 30, 2023 10:32

carellamartina added a commit that referenced this pull request Jul 3, 2023

collapsed job metadata in job result (#1754)

1837024

* collapsed jobInfoCard in jobResult * adjusted UncontrolledTooltip message * added collapse test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

collapsed job metadata in job result#1754

collapsed job metadata in job result#1754
drosetti merged 3 commits intodevelopfrom
job_result

carellamartina commented Jun 20, 2023

Uh oh!

codecov bot commented Jun 20, 2023 •

edited

Loading

Uh oh!

mlodic commented Jun 23, 2023

Uh oh!

carellamartina commented Jun 26, 2023

Uh oh!

Uh oh!

drosetti left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

carellamartina commented Jun 20, 2023

Description

Type of change

Checklist

Important Rules

Uh oh!

codecov bot commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mlodic commented Jun 23, 2023

Uh oh!

carellamartina commented Jun 26, 2023

Uh oh!

Uh oh!

drosetti left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jun 20, 2023 •

edited

Loading