Skip to content

Added time threshold (minutes ago) in the scan page #1637

Merged
drosetti merged 3 commits intodevelopfrom
job-run
Apr 4, 2023
Merged

Added time threshold (minutes ago) in the scan page #1637
drosetti merged 3 commits intodevelopfrom
job-run

Conversation

@drosetti
Copy link
Contributor

@drosetti drosetti commented Apr 4, 2023 •
edited
Loading

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Added time threshold (minutes ago) in the scan page

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector or playbook) was added or changed, in which case:
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added, its name was explicitly defined in test_file_scripts.py (not required for Observable Analyzers).
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

Screenshot from 2023-04-04 15-51-43

@drosetti drosetti requested a review from mlodic April 4, 2023 13:59
@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #1637 (75b917b) into develop (aa8820f) will increase coverage by 10.59%.
The diff coverage is 78.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1637       +/-   ##
============================================
+ Coverage    66.75%   77.34%   +10.59%     
============================================
  Files           95      280      +185     
  Lines         3706     9439     +5733     
  Branches       519     1054      +535     
============================================
+ Hits          2474     7301     +4827     
- Misses         941     1677      +736     
- Partials       291      461      +170
Impacted Files Coverage Δ
api_app/management/commands/update_analyzer.py 0.00% <0.00%> (ø)
api_app/migrations/0004_auto_20201112_0021.py 100.00% <ø> (ø)
api_app/serializers.py 77.85% <ø> (+9.43%) ⬆️
api_app/signals.py 92.30% <ø> (ø)
api_app/urls.py 83.33% <ø> (-16.67%) ⬇️
api_app/views.py 91.30% <ø> (ø)
...nalyzers_manager/observable_analyzers/mb_google.py 36.36% <36.36%> (ø)
...lyzers_manager/observable_analyzers/vt/vt3_base.py 39.80% <39.80%> (ø)
.../analyzers_manager/observable_analyzers/maxmind.py 29.89% <40.00%> (ø)
api_app/helpers.py 58.33% <41.66%> (-1.67%) ⬇️
... and 174 more

... and 99 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d59bc...75b917b. Read the comment docs.

@drosetti
Copy link
Contributor Author

drosetti commented Apr 4, 2023

Updated with the hours
Screenshot from 2023-04-04 17-23-04

@drosetti drosetti merged commit 75a7b49 into develop Apr 4, 2023
@drosetti drosetti deleted the job-run branch April 4, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlodic mlodic mlodic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drosetti @mlodic