Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leading | in nested patterns are incorrectly rejected #9001

Closed
Noratrieb opened this issue Jul 2, 2022 · 2 comments · Fixed by #9238
Closed

Leading | in nested patterns are incorrectly rejected #9001

Noratrieb opened this issue Jul 2, 2022 · 2 comments · Fixed by #9238
Labels
bug subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc.

Comments

@Noratrieb
Copy link

Environment

  • IntelliJ Rust plugin version: 0.4.173.4714-221
  • Rust toolchain version: 1.63.0-nightly
  • IDE name and version: CLion 2022.1.3
  • Operating system: Windows 11 + WSL2 (development in WSL2)

Problem description

Intellij-rust does not accept leading | in nested patterns, even though it is legal syntax.

Steps to reproduce

The following code is valid rust code:

fn main() {
    match Some(5) {
        Some(
            | 6
            | 7
        ) => true,
        | None
        | None => false,
        _ => false,
    };
}

Playground

But intellij-rust emits an error

a leading `|` is only allowed in a top-level pattern
@neonaot neonaot added subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc. bug rust Issues about new language features labels Jul 4, 2022
@afetisov
Copy link
Contributor

afetisov commented Aug 2, 2022

Hm, this is an explicit check in the IDE, and is part of the test suite. Was it at some point rejected by Rust and added as valid syntax later?

@afetisov
Copy link
Contributor

afetisov commented Aug 2, 2022

Indeed, leading | in nested or-patterns was allowed in 2021 and included in the final stabilization of or-patterns.

@afetisov afetisov mentioned this issue Aug 24, 2022
Merged
@Undin Undin removed the rust Issues about new language features label Aug 25, 2022
@bors bors bot closed this as completed in 81dc442 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug subsystem::code insight General label for issues related to code understanding: highlighting, completion, annotation, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ANN: allow leading | in nested or patterns
4 participants
@Undin @afetisov @Noratrieb @neonaot