This repository was archived by the owner on Mar 5, 2024. It is now read-only.
portabillity: Make unnecessary VLA into statically sized array#35
Merged
mczraf merged 1 commit intointel:masterfrom Nov 21, 2018
Merged
portabillity: Make unnecessary VLA into statically sized array#35mczraf merged 1 commit intointel:masterfrom
mczraf merged 1 commit intointel:masterfrom
Conversation
Contributor
Author
|
@mczraf ping |
Contributor
|
The intent of this feature is to prevent leakage through side-channel timing attacks. Your patch looks good, except for the fact it declares the variables dummy_key and dummy_state only if (key_size <= TC_SHA256_BLOCK_SIZE). It would be preferable if such declarations are made regardless of the key_size, i.e. before the if-clause. Please let me know if you can update your patch with this modification. Thanks! |
mczraf
force-pushed
the
master
branch
2 times, most recently
from
4fb05d5 to
323cd15
Compare
mped-oticon
force-pushed
the
issue30_vla
branch
from
ddb2a82 to
7c4ab60
Compare
Contributor
Author
|
@mczraf done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #30.