Skip to content

fix warning: unused manifest key #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Wenzel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix warning: unused manifest key #59

Wenzel wants to merge 1 commit into from

Conversation

@Wenzel
Copy link
Contributor

@Wenzel Wenzel commented Jan 13, 2026

Fix

warning: /home/mtarral/simulator-bindings/simics/Cargo.toml: unused manifest key: dependencies.simics-api-sys.version
warning: /home/mtarral/simulator-bindings/simics/Cargo.toml: unused manifest key: dependencies.simics-macro.version
warning: /home/mtarral/simulator-bindings/simics/Cargo.toml: unused manifest key: build-dependencies.simics-api-sys.version
warning: /home/mtarral/simulator-bindings/simics/Cargo.toml: unused manifest key: build-dependencies.simics-build-utils.version
warning: /home/mtarral/simulator-bindings/simics/Cargo.toml: unused manifest key: build-dependencies.simics-macro.version
warning: /home/mtarral/simulator-bindings/simics-macro/Cargo.toml: unused manifest key: dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/simics-macro/Cargo.toml: unused manifest key: dependencies.simics-api-sys.version
warning: /home/mtarral/simulator-bindings/simics-macro/Cargo.toml: unused manifest key: dependencies.simics-sign.version
warning: /home/mtarral/simulator-bindings/cargo-simics-build/Cargo.toml: unused manifest key: dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/cargo-simics-build/Cargo.toml: unused manifest key: dependencies.simics-package.version
warning: /home/mtarral/simulator-bindings/cargo-simics-build/Cargo.toml: unused manifest key: dependencies.simics-sign.version
warning: /home/mtarral/simulator-bindings/simics-api-sys/Cargo.toml: unused manifest key: build-dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/simics-build-utils/Cargo.toml: unused manifest key: dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/simics-test/Cargo.toml: unused manifest key: dependencies.cargo-simics-build.version
warning: /home/mtarral/simulator-bindings/simics-test/Cargo.toml: unused manifest key: dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/tests/packages/hello-world/Cargo.toml: unused manifest key: dependencies.simics.version
warning: /home/mtarral/simulator-bindings/tests/packages/hello-world/Cargo.toml: unused manifest key: dev-dependencies.ispm-wrapper.version
warning: /home/mtarral/simulator-bindings/tests/packages/hello-world/Cargo.toml: unused manifest key: dev-dependencies.simics-test.version
warning: /home/mtarral/simulator-bindings/tests/packages/hello-world/Cargo.toml: unused manifest key: build-dependencies.simics-build-utils.version
warning: /home/mtarral/simulator-bindings/simics-package/Cargo.toml: version requirement `0.9.34+deprecated` for dependency `serde_yaml` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

@Wenzel Wenzel requested a review from Copilot January 13, 2026 16:34
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes redundant version specifications from workspace dependencies in Cargo.toml files across the project. When using workspace = true, the version field is both unnecessary and causes warnings since the version is already specified in the workspace's Cargo.toml.

Changes:

  • Removed explicit version fields from all workspace dependency declarations
  • Fixed serde_yaml version specification to remove semver metadata suffix

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/packages/hello-world/Cargo.toml Removed version fields from workspace dependencies (simics, simics-build-utils, ispm-wrapper, simics-test)
simics/Cargo.toml Removed version fields from workspace dependencies in both dependencies and build-dependencies sections
simics-test/Cargo.toml Removed version fields from workspace dependencies (cargo-simics-build, ispm-wrapper)
simics-package/Cargo.toml Removed semver metadata suffix from serde_yaml version specification
simics-macro/Cargo.toml Removed version fields from workspace dependencies (ispm-wrapper, simics-api-sys, simics-sign)
simics-build-utils/Cargo.toml Removed version fields from workspace dependencies (ispm-wrapper, simics-api-sys)
simics-api-sys/Cargo.toml Removed version field from workspace dependency (ispm-wrapper)
cargo-simics-build/Cargo.toml Removed version fields from workspace dependencies (ispm-wrapper, simics-package, simics-sign)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Wenzel