Update OpenVINO EP to latest version - 2019 R3.1#7
Closed
Conversation
…d GPU_FP16 unit test. Removes compatibility with 2018.R5 and 2019.R1.1
merging master into branch
Updating to latest master
…ed python wheel packaging
…assing for CPU_FP32.
psfoley
commented
Oct 29, 2019
smkarlap
reviewed
Oct 29, 2019
smkarlap
reviewed
Oct 29, 2019
smkarlap
reviewed
Oct 29, 2019
smkarlap
reviewed
Oct 29, 2019
smkarlap
reviewed
Oct 29, 2019
| # whose value is set in INTEL_CVSDK_DIR variable by running the setupvars.sh script | ||
| if (onnxruntime_USE_OPENVINO_BINARY) | ||
| if ($ENV{INTEL_CVSDK_DIR} MATCHES "2019.1") | ||
| if ($ENV{INTEL_CVSDK_DIR} MATCHES "2019.3") |
There was a problem hiding this comment.
This check can be moved to Line 284 as
if ( NOT $ENV{INTEL_CVSDK_DIR} MATCHES "2019.3" )
message(FATAL_ERROR ...)
endif()
And the rest of the code no longer needs to be enclosed within if blocks for version checks
|
Also, run clang-format tool to format the source according to ONNXRuntime specs. |
…INO version checks
|
Looks good to me |
suryasidd
reviewed
Oct 31, 2019
cmake/onnxruntime_providers.cmake
Outdated
| "${ONNXRUNTIME_ROOT}/core/providers/openvino/openvino_mo/*.py" | ||
| ) | ||
|
|
||
| message($ENV{INTEL_CVSDK_DIR}) |
There was a problem hiding this comment.
Can you please remove the message here?
|
|
||
| if (node->OpType() == "Mul" || node->OpType() == "Add" || node->OpType() == "Div" || node->OpType() == "Sub") { | ||
| for (size_t i = 0; i < node->InputDefs().size(); i++) { | ||
| if (node->InputDefs()[i]->TypeAsProto()->tensor_type().elem_type() == ONNX_NAMESPACE::TensorProto_DataType::TensorProto_DataType_INT64) { |
There was a problem hiding this comment.
Do you think we should have a logic to reject for all unsupported data types? I can see George asking why only int64, this is not generic.
Author
|
Merged to MSFT/OnnxRuntime Master |
sfatimar
pushed a commit
that referenced
this pull request
Aug 28, 2023
### Description
Release OrtEnv before main function returns. Before this change, OrtEnv
is deleted when C/C++ runtime destructs all global variables in ONNX
Runtime's core framework.
The callstack is like this:
```
* frame #0: 0x00007fffee39f5a6 libonnxruntime.so.1.16.0`onnxruntime::Environment::~Environment(this=0x00007fffee39fbf2) at environment.h:20:7
frame #1: 0x00007fffee39f614 libonnxruntime.so.1.16.0`std::default_delete<onnxruntime::Environment>::operator()(this=0x00007ffff4c30e50, __ptr=0x0000000005404b00) const at unique_ptr.h:85:2
frame #2: 0x00007fffee39edca libonnxruntime.so.1.16.0`std::unique_ptr<onnxruntime::Environment, std::default_delete<onnxruntime::Environment>>::~unique_ptr(this=0x5404b00) at unique_ptr.h:361:17
frame #3: 0x00007fffee39e2ab libonnxruntime.so.1.16.0`OrtEnv::~OrtEnv(this=0x00007ffff4c30e50) at ort_env.cc:43:1
frame #4: 0x00007fffee39fa96 libonnxruntime.so.1.16.0`std::default_delete<OrtEnv>::operator()(this=0x00007fffefff8f78, __ptr=0x00007ffff4c30e50) const at unique_ptr.h:85:2
frame #5: 0x00007fffee39f394 libonnxruntime.so.1.16.0`std::unique_ptr<OrtEnv, std::default_delete<OrtEnv>>::~unique_ptr(this=0x7ffff4c30e50) at unique_ptr.h:361:17
frame #6: 0x00007ffff78574b5 libc.so.6`__run_exit_handlers + 261
frame #7: 0x00007ffff7857630 libc.so.6`exit + 32
frame #8: 0x00007ffff783feb7 libc.so.6`__libc_start_call_main + 135
frame #9: 0x00007ffff783ff60 libc.so.6`__libc_start_main@@GLIBC_2.34 + 128
frame #10: 0x0000000000abbdee node`_start + 46
```
After this change, OrtEnv will be deleted before the main function
returns and nodejs is still alive.
RyanMetcalfeInt8
pushed a commit
to RyanMetcalfeInt8/onnxruntime
that referenced
this pull request
Jul 25, 2025
Merging main (rev: 986b66a) to develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Brings the OpenVINO EP up to date with the latest available version (2019 3.1)
Motivation and Context
Functional and Security Updates
Support for 10th generation Intel® Core™ processors
Network Loading Optimizations
For more details, please look at the link below
https://software.intel.com/en-us/articles/OpenVINO-RelNotes