Resolve error messages on exit when using python bindings#583
Merged
saurabhkale17 merged 1 commit intoovep-developfrom Feb 18, 2025
Merged
Resolve error messages on exit when using python bindings#583saurabhkale17 merged 1 commit intoovep-developfrom
saurabhkale17 merged 1 commit intoovep-developfrom
Conversation
Python bindings don't call the provider factory shutdown method. We relied on this to avoid destruction order issues with statically scoped ov::Core objects. Refactor ov core and shared context lifetimes such that we don't need to rely on shutdown calls to manage life times and we avoid a static lifetime of the core.
Author
|
LGTM |
jatinwadhwa921
added a commit
that referenced
this pull request
Feb 18, 2025
Python bindings don't call the provider factory shutdown method. We relied on this to avoid destruction order issues with statically scoped ov::Core objects. Refactor ov core and shared context lifetimes such that we don't need to rely on shutdown calls to manage life times and we avoid a static lifetime of the core. Co-authored-by: Eric Crawford <[email protected]>
ankitm3k
pushed a commit
that referenced
this pull request
Feb 21, 2025
Python bindings don't call the provider factory shutdown method. We relied on this to avoid destruction order issues with statically scoped ov::Core objects. Refactor ov core and shared context lifetimes such that we don't need to rely on shutdown calls to manage life times and we avoid a static lifetime of the core. Co-authored-by: Eric Crawford <[email protected]>
jatinwadhwa921
added a commit
that referenced
this pull request
Feb 21, 2025
Python bindings don't call the provider factory shutdown method. We relied on this to avoid destruction order issues with statically scoped ov::Core objects. Refactor ov core and shared context lifetimes such that we don't need to rely on shutdown calls to manage life times and we avoid a static lifetime of the core. Co-authored-by: Eric Crawford <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python bindings don't call the provider factory shutdown method. We relied on this to avoid destruction order issues with statically scoped ov::Core objects.
Refactor ov core and shared context lifetimes such that we don't need to rely on shutdown
calls to manage life times and we avoid a static lifetime of the core.