Skip to content

Comments

Python files are cleaned#5

Closed
gundaarx wants to merge 1 commit intoov2019r2from
ov2019r2-clean
Closed

Python files are cleaned#5
gundaarx wants to merge 1 commit intoov2019r2from
ov2019r2-clean

Conversation

@gundaarx
Copy link

@gundaarx gundaarx commented Sep 3, 2019

Python files in ov2019R2 are cleaned.
Clang Format is used

@gundaarx gundaarx requested a review from suryasidd September 3, 2019 20:54
@suryasidd suryasidd closed this Sep 4, 2019
@gundaarx gundaarx deleted the ov2019r2-clean branch September 5, 2019 00:47
MaajidKhan pushed a commit that referenced this pull request Mar 29, 2021
* Test re-using page layout from current ONNX Runtime website for docs

* Add content for documentation on website

* Fixed most broken links

* Copy just-the-docs theme sources into repo

* Remove local theme files as this did not work with GitHub

* Remove nojekyll file

* Move image assets into single location

* Add Contents to markdown files and ensure only one h1

* Update after review

* Fix img links

* Add trailing slash to main nav links

* Fix broken links on main docs page

* Re-fix broken links on main docs page

* Fix broken links #3

* Fix broken links #4

* Fix broken links #5

* Fix broken links #6

* Fix paths to global assets

* Add updates since fork

* Update custom op docs

* Fix link
sfatimar pushed a commit that referenced this pull request Aug 28, 2023
### Description
Release OrtEnv before main function returns. Before this change, OrtEnv
is deleted when C/C++ runtime destructs all global variables in ONNX
Runtime's core framework.
The callstack is like this:
```
  * frame #0: 0x00007fffee39f5a6 libonnxruntime.so.1.16.0`onnxruntime::Environment::~Environment(this=0x00007fffee39fbf2) at environment.h:20:7
    frame #1: 0x00007fffee39f614 libonnxruntime.so.1.16.0`std::default_delete<onnxruntime::Environment>::operator()(this=0x00007ffff4c30e50, __ptr=0x0000000005404b00) const at unique_ptr.h:85:2
    frame #2: 0x00007fffee39edca libonnxruntime.so.1.16.0`std::unique_ptr<onnxruntime::Environment, std::default_delete<onnxruntime::Environment>>::~unique_ptr(this=0x5404b00) at unique_ptr.h:361:17
    frame #3: 0x00007fffee39e2ab libonnxruntime.so.1.16.0`OrtEnv::~OrtEnv(this=0x00007ffff4c30e50) at ort_env.cc:43:1
    frame #4: 0x00007fffee39fa96 libonnxruntime.so.1.16.0`std::default_delete<OrtEnv>::operator()(this=0x00007fffefff8f78, __ptr=0x00007ffff4c30e50) const at unique_ptr.h:85:2
    frame #5: 0x00007fffee39f394 libonnxruntime.so.1.16.0`std::unique_ptr<OrtEnv, std::default_delete<OrtEnv>>::~unique_ptr(this=0x7ffff4c30e50) at unique_ptr.h:361:17
    frame #6: 0x00007ffff78574b5 libc.so.6`__run_exit_handlers + 261
    frame #7: 0x00007ffff7857630 libc.so.6`exit + 32
    frame #8: 0x00007ffff783feb7 libc.so.6`__libc_start_call_main + 135
    frame #9: 0x00007ffff783ff60 libc.so.6`__libc_start_main@@GLIBC_2.34 + 128
    frame #10: 0x0000000000abbdee node`_start + 46
```
After this change, OrtEnv will be deleted before the main function
returns and nodejs is still alive.
RyanMetcalfeInt8 pushed a commit to RyanMetcalfeInt8/onnxruntime that referenced this pull request Jul 25, 2025
* Populate ovep abi based on example ep

* remove ocl headers

* Add openvino plugin ep provider tests

* move some factory implementations out of header

* initial crude device support device implementation

* Create multiple factories for device type/meta device

* only expose new ABI

* Provider entry

* remove factory impl

* Add disable copy and move macro

* rearrange ov factory functions

* enumerate AUTO

* Match OV devices via device id

* Only assign devices which are passed to CreateEp

* update provider api based on upstream

* Only expose a default + AUTO ov factory

* Implement CreateIExecutionProvider

* format ov_factory

* fix linux build

* Create separate dll for plugin

* fix linux build for tests

* use new plugin for tests

* Implement newly added apis that aren't optional

* Add linker language

* update meta data usage to match upstream

* onnxruntime making the symbol disappear?

* wrong shared library function?

* linker script for sure is getting invoked?

* don't gc sections

* linker language v2

* hack only link shared library against static on windows.

* only static lib on windows v2

* fixup apple path

* fix up sources

* add missing sources

* skip tests on linux since we aren't buildling a plugin for it yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants