Merged
Conversation
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
suryasidd
force-pushed
the
openvino_R1
branch
3 times, most recently
from
3a36bb0 to
72fc6a9
Compare
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
|
Use the coding style followed in the rest of the code ( opening braces must follow be in the same line as the if statement, and closing braces must align with the if statement's indentation). |
smkarlap
reviewed
Jul 17, 2019
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
MaajidKhan
pushed a commit
that referenced
this pull request
Mar 29, 2021
* Test re-using page layout from current ONNX Runtime website for docs * Add content for documentation on website * Fixed most broken links * Copy just-the-docs theme sources into repo * Remove local theme files as this did not work with GitHub * Remove nojekyll file * Move image assets into single location * Add Contents to markdown files and ensure only one h1 * Update after review * Fix img links * Add trailing slash to main nav links * Fix broken links on main docs page * Re-fix broken links on main docs page * Fix broken links #3 * Fix broken links #4 * Fix broken links #5 * Fix broken links #6 * Fix paths to global assets * Add updates since fork * Update custom op docs * Fix link
sfatimar
pushed a commit
that referenced
this pull request
Aug 28, 2023
### Description
Release OrtEnv before main function returns. Before this change, OrtEnv
is deleted when C/C++ runtime destructs all global variables in ONNX
Runtime's core framework.
The callstack is like this:
```
* frame #0: 0x00007fffee39f5a6 libonnxruntime.so.1.16.0`onnxruntime::Environment::~Environment(this=0x00007fffee39fbf2) at environment.h:20:7
frame #1: 0x00007fffee39f614 libonnxruntime.so.1.16.0`std::default_delete<onnxruntime::Environment>::operator()(this=0x00007ffff4c30e50, __ptr=0x0000000005404b00) const at unique_ptr.h:85:2
frame #2: 0x00007fffee39edca libonnxruntime.so.1.16.0`std::unique_ptr<onnxruntime::Environment, std::default_delete<onnxruntime::Environment>>::~unique_ptr(this=0x5404b00) at unique_ptr.h:361:17
frame #3: 0x00007fffee39e2ab libonnxruntime.so.1.16.0`OrtEnv::~OrtEnv(this=0x00007ffff4c30e50) at ort_env.cc:43:1
frame #4: 0x00007fffee39fa96 libonnxruntime.so.1.16.0`std::default_delete<OrtEnv>::operator()(this=0x00007fffefff8f78, __ptr=0x00007ffff4c30e50) const at unique_ptr.h:85:2
frame #5: 0x00007fffee39f394 libonnxruntime.so.1.16.0`std::unique_ptr<OrtEnv, std::default_delete<OrtEnv>>::~unique_ptr(this=0x7ffff4c30e50) at unique_ptr.h:361:17
frame #6: 0x00007ffff78574b5 libc.so.6`__run_exit_handlers + 261
frame #7: 0x00007ffff7857630 libc.so.6`exit + 32
frame #8: 0x00007ffff783feb7 libc.so.6`__libc_start_call_main + 135
frame #9: 0x00007ffff783ff60 libc.so.6`__libc_start_main@@GLIBC_2.34 + 128
frame #10: 0x0000000000abbdee node`_start + 46
```
After this change, OrtEnv will be deleted before the main function
returns and nodejs is still alive.
RyanMetcalfeInt8
pushed a commit
to RyanMetcalfeInt8/onnxruntime
that referenced
this pull request
Jul 25, 2025
Update develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Motivation and Context