rdt: correct prometheus metric types

marquiz · marquiz · commit d36372a52806 · 2025-12-09T11:07:39.000+02:00
Align with the the OTEL metrics.
diff --git a/pkg/rdt/prometheus.go b/pkg/rdt/prometheus.go
@@ -127,10 +127,22 @@ func (c *collector) collectGroupMetrics(ch chan<- prometheus.Metric, g ResctrlGr
 		for feature, value := range data {
 			ch <- prometheus.MustNewConstMetric(
 				c.describeL3(feature),
-				prometheus.CounterValue,
+				promValueTypeL3(feature),
 				float64(value),
 				labels...,
 			)
 		}
 	}
 }
+
+// promValueTypeL3 returns Prometheus value type for given L3 metric.
+func promValueTypeL3(feature string) prometheus.ValueType {
+	switch feature {
+	case "llc_occupancy":
+		return prometheus.GaugeValue
+	case "mbm_local_bytes", "mbm_total_bytes":
+		return prometheus.CounterValue
+	default:
+		return prometheus.GaugeValue
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -127,10 +127,22 @@ func (c *collector) collectGroupMetrics(ch chan<- prometheus.Metric, g ResctrlGr`
`127`	`127`	`for feature, value := range data {`
`128`	`128`	`ch <- prometheus.MustNewConstMetric(`
`129`	`129`	`c.describeL3(feature),`
`130`		`- prometheus.CounterValue,`
	`130`	`+ promValueTypeL3(feature),`
`131`	`131`	`float64(value),`
`132`	`132`	`labels...,`
`133`	`133`	`)`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`	`}`
	`137`	`+`
	`138`	`+// promValueTypeL3 returns Prometheus value type for given L3 metric.`
	`139`	`+func promValueTypeL3(feature string) prometheus.ValueType {`
	`140`	`+ switch feature {`
	`141`	`+ case "llc_occupancy":`
	`142`	`+ return prometheus.GaugeValue`
	`143`	`+ case "mbm_local_bytes", "mbm_total_bytes":`
	`144`	`+ return prometheus.CounterValue`
	`145`	`+ default:`
	`146`	`+ return prometheus.GaugeValue`
	`147`	`+ }`
	`148`	`+}`