Skip to content
This repository was archived by the owner on Mar 28, 2018. It is now read-only.

Docs: metrics: network: Clarify pre-process and running#946

Merged
jodh-intel merged 1 commit intointel:masterfrom
grahamwhaley:20170605_metrics_doc_typo
Jun 6, 2017
Merged

Docs: metrics: network: Clarify pre-process and running#946
jodh-intel merged 1 commit intointel:masterfrom
grahamwhaley:20170605_metrics_doc_typo

Conversation

@grahamwhaley
Copy link
Copy Markdown

@grahamwhaley grahamwhaley commented Jun 5, 2017

Correct the typo in the network metrics build command, and clarify
how the tests can be run by hand after pre-processing.

Fixes: #944

Signed-off-by: Graham Whaley [email protected]

Docs: metrics: network: Clarify pre-process and running
cdf5cf1 
Correct the typo in the network metrics build command, and clarify
how the tests can be run by hand after pre-processing.

Signed-off-by: Graham Whaley <[email protected]>
@grahamwhaley grahamwhaley requested a review from GabyCT June 5, 2017 09:40
@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jun 5, 2017 •
edited by dlespiau
Loading

lgtm

Approved with PullApprove

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Jun 5, 2017 •
edited by dlespiau
Loading

qa-passed

Approved with PullApprove

@grahamwhaley
Copy link
Copy Markdown
Author

grahamwhaley commented Jun 5, 2017

Hi @jodh-intel @gorozco1 Looks like Travis is failing as the curl of the autoconf archive is giving a 502 Bad Gateway error. Not sure if that is a temporary or permanent issue - any thoughts?
If you try the url:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_valgrind_check.m4
then what I see in the logs is a 193 byte download instead of a 8852 byte download - that was the clue ;-)

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jun 5, 2017

Hi @grahamwhaley - it does indeed look like that site is borked atm (you can't even download via cvs).

I think we might want to rethink our approach for obtaining autoconf-archive (#876 (review)). It's "overkill" to download the whole archive when we only want 2 files, but if we're pulling a stable release, not only do we know which version of the code we're actually using, but we have more choices wrt a reliable download site due to large number of available mirrors.

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jun 5, 2017

... alternatively, we could just enable https://docs.travis-ci.com/user/caching/ so that once we have a good copy, we'll continue to use that.

@jodh-intel jodh-intel mentioned this pull request Jun 5, 2017
Merged
@GabyCT
Copy link
Copy Markdown
Contributor

GabyCT commented Jun 5, 2017 •
edited by dlespiau
Loading

lgtm

Approved with PullApprove

@GabyCT GabyCT mentioned this pull request Jun 5, 2017
Merged
@jodh-intel jodh-intel mentioned this pull request Jun 5, 2017
Merged
iphutch
iphutch approved these changes Jun 5, 2017
View reviewed changes
Copy link
Copy Markdown

@iphutch iphutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a docs team perspective.

@jodh-intel jodh-intel merged commit 136c7ed into intel:master Jun 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rcaballeromx rcaballeromx Awaiting requested review from rcaballeromx

@GabyCT GabyCT Awaiting requested review from GabyCT

1 more reviewer

@iphutch iphutch iphutch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grahamwhaley @jodh-intel @chavafg @GabyCT @iphutch