build: remove requeriment to have a recent autoconf-archive by gorozco1 · Pull Request #911 · intel/cc-oci-runtime

gorozco1 · 2017-05-16T19:59:15Z

Asking for a recent autoconf-archive makes it extra difficult to build cc-oci-runtime in older distros: Ubuntu 16.04, Ubuntu 16.10 Fedora 24.

With this patch I am removing the requeriment for a recent autoconf-archive as well as references to AX_VALGRIND_DFLT.

Added --disable-valgrind-sgcheck to default build options

Fixes #888 and #887

jcvenegas · 2017-05-16T20:30:51Z

It is need to call to AX_VALGRIND_DFLT before AX_VALGRIND_CHECK
https://www.gnu.org/software/autoconf-archive/ax_valgrind_check.html

jcvenegas · 2017-05-16T20:57:32Z

configure.ac

+	ifdef([$1], true, [AC_FATAL([Please install autoconf-archive],)])
 ])

-MACRO_CHECK([AX_VALGRIND_DFLT])


This macro will check for AX_VALGRIND_CHECK AX_CODE_COVERAGE that are provided by autoconf archive.

I wonder if we can modify MACRO_CHECK, to not fail de execution but let us know if the AX_VALGRIND_CHECK and others are defined.

If they are defined the m4 files exist and we could use valgrind and code coverage, otherwise we continue with the execution without execute valgrind test.

Hi @jcvenegas - I agree that that would be a nice optimisation but I don't think that needs to block this PR (since we already fail if the expected version of autoconf-archive isn't installed). Could you raise an issue to capture the idea maybe?

agree @jodh-intel , docuemented in #917, lets merge this change

amshinde · 2017-05-16T21:05:44Z

@jcvenegas I think the AX_VALGRIND_DFLT is used for setting the defaults, in our case never running the sgcheck tool. We can get away with this by passing --disable-valgrind-sgcheck to configure.

chavafg · 2017-05-16T21:13:25Z

qa-failed

chavafg · 2017-05-16T22:01:44Z

got these lines:

make[4]: Leaving directory '/home/cloud/go/src/github.com/01org/cc-oci-runtime/cc-oci-runtime-2.1.8/_build/sub'
make[3]: Leaving directory '/home/cloud/go/src/github.com/01org/cc-oci-runtime/cc-oci-runtime-2.1.8/_build/sub'
make[2]: Leaving directory '/home/cloud/go/src/github.com/01org/cc-oci-runtime/cc-oci-runtime-2.1.8/_build/sub'
Makefile:5413: recipe for target 'check-valgrind-local' failed
make[1]: *** [check-valgrind-local] Error 2
make[1]: Leaving directory '/home/cloud/go/src/github.com/01org/cc-oci-runtime/cc-oci-runtime-2.1.8/_build/sub'
Makefile:4985: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1

jcvenegas · 2017-05-16T22:17:04Z

@amshinde thanks for clarify , so adding adding --disable-valgrind-sgcheck should fix that issue.

This reverts commit a210cc4. Signed-off-by: Geronimo Orozco <[email protected]>

chavafg · 2017-05-17T00:21:00Z

qa-failed

chavafg · 2017-05-17T01:56:06Z

qa-failed

devimc · 2017-05-17T16:06:52Z

I think @chavafg should add --disable-valgrind-sgcheck in his CI

chavafg · 2017-05-17T16:54:54Z

The failures is happening on make distcheck, so the makefile should be updated in this line:
https://github.com/01org/cc-oci-runtime/blob/master/Makefile.am#L161

with the --disable-valgrind-sgcheck flag.

chavafg · 2017-05-17T17:19:54Z

qa-failed

chavafg · 2017-05-17T20:33:26Z

qa-passed

gorozco1 · 2017-05-17T23:05:40Z

\o/

jodh-intel

lgtm

jodh-intel · 2017-05-18T08:02:41Z

autogen.sh

 --localstatedir=/var \
--prefix=/usr"
+--prefix=/usr \
+--disable-valgrind-sgcheck"


I see that this change will automatically be applied to the OBS builds, since the files in data/obs-packaging/ call ./autogen.sh.

jodh-intel · 2017-05-18T08:02:45Z

configure.ac

+	ifdef([$1], true, [AC_FATAL([Please install autoconf-archive],)])
 ])

-MACRO_CHECK([AX_VALGRIND_DFLT])


Hi @jcvenegas - I agree that that would be a nice optimisation but I don't think that needs to block this PR (since we already fail if the expected version of autoconf-archive isn't installed). Could you raise an issue to capture the idea maybe?

jcvenegas · 2017-05-18T16:05:14Z

lgtm

jcvenegas · 2017-05-18T16:13:59Z

@rcaballeromx could you review this change?

jcvenegas · 2017-05-18T16:48:23Z

@gorozco1 could you add to the commit message that fixes #888 ( and probably ##887 ? )

AX_VALGRIND_DFLT makes it imposible to build cc-oci-runtime in older distros. Hence we need to disable this checks in order to build successfuly on Ubuntu 16.04, Ubuntu 16.10 and Fedora 24. Added --disable-valgrind-sgcheck to default build options Fixes intel#888 and intel#887 Signed-off-by: Geronimo Orozco <[email protected]>

amshinde · 2017-05-18T17:06:21Z

lgtm

cc-oci-runtime OBS builds needed 2 patches to build successfully on Ubuntu 16.04, Ubuntu 16.10 and F24. These patches already have been sent to the oficial repo on PR intel#911 Besides these patches, this commit adds improvements to the OBS automation tooling for cc-oci-runtime, and the updated changelog sent to the OBS builds. Signed-off-by: Geronimo Orozco <[email protected]>

chavafg · 2017-05-18T17:42:43Z

qa-passed

gorozco1 added the in progress label May 16, 2017

gorozco1 requested review from amshinde, devimc and jodh-intel May 16, 2017 19:59

gorozco1 changed the title ~~M4 version revert~~ remove requeriment to have a really recent autoconf-archive May 16, 2017

gorozco1 changed the title ~~remove requeriment to have a really recent autoconf-archive~~ remove requeriment to have arecent autoconf-archive May 16, 2017

gorozco1 changed the title ~~remove requeriment to have arecent autoconf-archive~~ remove requeriment to have a recent autoconf-archive May 16, 2017

gorozco1 force-pushed the m4-version-revert branch from c23a22a to a6e1cd3 Compare May 16, 2017 20:02

gorozco1 changed the title ~~remove requeriment to have a recent autoconf-archive~~ build: remove requeriment to have a recent autoconf-archive May 16, 2017

jcvenegas reviewed May 16, 2017

View reviewed changes

Revert "versions: Specifies a version of autoconf-archive"

61e9dbc

This reverts commit a210cc4. Signed-off-by: Geronimo Orozco <[email protected]>

gorozco1 force-pushed the m4-version-revert branch 3 times, most recently from f94fbbd to 81abf0f Compare May 16, 2017 23:40

grahamwhaley mentioned this pull request May 17, 2017

install: Extract autoconf-archive install to separate script #876

Merged

gorozco1 force-pushed the m4-version-revert branch from 81abf0f to 0f92144 Compare May 17, 2017 18:14

jodh-intel approved these changes May 18, 2017

View reviewed changes

gorozco1 force-pushed the m4-version-revert branch from 0f92144 to 161aa5c Compare May 18, 2017 16:54

gorozco1 mentioned this pull request May 18, 2017

build: Update cc-oci-runtime obs builds with master #919

Merged

rcaballeromx approved these changes May 18, 2017

View reviewed changes

jcvenegas merged commit dff5128 into intel:master May 18, 2017

jcvenegas removed the in progress label May 18, 2017

gorozco1 mentioned this pull request May 18, 2017

cc-oci-runtime: Does not compile on FC24 #887

Closed

gorozco1 deleted the m4-version-revert branch May 19, 2017 00:38

Conversation

gorozco1 commented May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcvenegas commented May 16, 2017

Uh oh!

jcvenegas May 16, 2017

Choose a reason for hiding this comment

Uh oh!

jodh-intel May 18, 2017

Choose a reason for hiding this comment

Uh oh!

jcvenegas May 18, 2017

Choose a reason for hiding this comment

Uh oh!

amshinde commented May 16, 2017

Uh oh!

chavafg commented May 16, 2017 • edited by dlespiau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chavafg commented May 16, 2017

Uh oh!

jcvenegas commented May 16, 2017

Uh oh!

chavafg commented May 17, 2017

Uh oh!

chavafg commented May 17, 2017

Uh oh!

devimc commented May 17, 2017

Uh oh!

chavafg commented May 17, 2017

Uh oh!

chavafg commented May 17, 2017

Uh oh!

chavafg commented May 17, 2017 • edited by dlespiau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gorozco1 commented May 17, 2017

Uh oh!

jodh-intel left a comment

Choose a reason for hiding this comment

Uh oh!

jodh-intel May 18, 2017

Choose a reason for hiding this comment

Uh oh!

jodh-intel May 18, 2017

Choose a reason for hiding this comment

Uh oh!

jcvenegas commented May 18, 2017 • edited by dlespiau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcvenegas commented May 18, 2017

Uh oh!

jcvenegas commented May 18, 2017

Uh oh!

amshinde commented May 18, 2017 • edited by dlespiau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chavafg commented May 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gorozco1 commented May 16, 2017 •

edited

Loading

chavafg commented May 16, 2017 •

edited by dlespiau

Loading

chavafg commented May 17, 2017 •

edited by dlespiau

Loading

jcvenegas commented May 18, 2017 •

edited by dlespiau

Loading

amshinde commented May 18, 2017 •

edited by dlespiau

Loading