Skip to content

Conversation

@haerdib
Copy link
Contributor

@haerdib haerdib commented Aug 18, 2021

  • removal of communication block (speficially functions localized_payload_with_buffer and check_message_sig_with_buffer) because they are now implemented in the sp_finality_grandpa crate which implements no_std.
  • adaptions (mostly copy paste) according to substrate sc-finality-grandpa justifications.rs
  • chain relay will not panic upon faulty justification but print an error message

@haerdib haerdib marked this pull request as draft August 18, 2021 09:12
@haerdib haerdib force-pushed the bh-update-justifications branch from 6349eaa to b941434 Compare August 18, 2021 09:14
@haerdib haerdib marked this pull request as ready for review August 18, 2021 11:40
AuthorityId,
>;

mod communication {
Copy link
Contributor Author

@haerdib haerdib Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete. This can be imported directly from substrate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I always like it when PRs actually remove code. :D

@haerdib haerdib requested review from clangenb and murerfel and removed request for clangenb August 18, 2021 13:21
@haerdib haerdib linked an issue Aug 18, 2021 that may be closed by this pull request
AuthorityId,
>;

mod communication {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I always like it when PRs actually remove code. :D

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update justification logic

3 participants