Skip to content

skip marblerun thread unless really working as an attesteer #1314

New issue
New issue
Closed
#1345
Closed
skip marblerun thread unless really working as an attesteer#1314
#1345
Assignees
brenzi
@brenzi

Description

@brenzi
brenzi
opened on May 22, 2023

The following lines are gated by the dcap compiler flag which makes no sense, because every flavor can do dcap (without using Marblerun), not only the attesteer
These lines are blocking if it can't find Marblerun, which is very annoying

worker/service/src/main.rs

Lines 431 to 443 in ee0e1b3

#[cfg(feature = "dcap")]
let marblerun_base_url =
run_config.marblerun_base_url.unwrap_or("http://localhost:9944".to_owned());
#[cfg(feature = "dcap")]
fetch_marblerun_events_every_hour(
node_api.clone(),
enclave.clone(),
tee_accountid.clone(),
is_development_mode,
trusted_url.clone(),
marblerun_base_url.clone(),
);

Options

  1. cli flag --marblerun enables the use of marblerun
    • not nice because the attesteer should probably be a standalone binary. it makes no sense building an SCV or OCW with this enabled
  2. compiler flag attesteer
    • yet another flag and it's only used in one place - currently

I favor 2 but actually, I'd prefer if SCV, OCW, TEEracle, Attesteer would yield different binary names

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions