Update polkadot-v0.9.29 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sidechain_block` renaming
OverOrion
force-pushed
the
szp/polkadot-v0.9.29
branch
from
f86e999 to
362291f
Compare
OverOrion
force-pushed
the
szp/polkadot-v0.9.29
branch
from
d484989 to
7a193e1
Compare
haerdib
reviewed
Oct 19, 2022
| pallet-sidechain = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" } | ||
| pallet-teeracle = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" } | ||
| pallet-teerex = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" } | ||
| pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" } |
Contributor
There was a problem hiding this comment.
Suggested change
| pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" } | |
| pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.29" } |
and for the others below as well
haerdib
approved these changes
Oct 20, 2022
Contributor
|
Ah, sorry, I forgot to check for the scripts: Can you update the launch scripts (e.g. zombienet and polkadot-launch) to v0.9.29 as well? Can be easily done via search and replace. |
clangenb
approved these changes
Oct 24, 2022
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
No, it is fine for me, we should only test the runtime upgrade, when we actually perform one.
clangenb
requested changes
Oct 24, 2022
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
One minor issue. Please bump the spec version of the shell-runtime as well. :)
clangenb
reviewed
Oct 26, 2022
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Also bump the shell-runtime spec_version here please:
clangenb
approved these changes
Oct 26, 2022
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Nice, looks good to me!
| command = "./target/release/integritee-collator" | ||
| ws_port = 9995 | ||
|
|
||
| #this is not working !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.