[BUG]: The github_repository resource churns on vulnerability_alerts if not explicitly set

Expected Behavior

When creating a new repository with the github_repository resource, this should not churn if vulnerability_alerts is not set.

Actual Behavior

If vulnerability_alerts is not set it will constantly churn.

Terraform Version

n/a

Affected Resource(s)

github_repository

Terraform Configuration Files

resource "github_repository" "test" {
  name         = "test"
}

Steps to Reproduce

Apply the above resource and then run a plan.

This issue is being caused by a missing Computed: true value on the schema. I'll open a PR to fix this, but long term this attribute should be deprecated and handled by it's own resource.

Debug Output

No response

Panic Output

No response

Code of Conduct

I agree to follow this project's Code of Conduct

It also looks like if a repository is created with an explicit value for vulnerability_alerts that doesn't match the default it will also churn.

The code to fix this is currently in #2476 but I'm planning on opening a seperate PR for this change before that gets merged.

I'm having this issue running acceptance tests:

 data_source_github_repository_autolink_references_test.go:44: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # github_repository.test will be updated in-place
          ~ resource "github_repository" "test" {
                id                          = "tf-acc-test-uzqg7"
                name                        = "tf-acc-test-uzqg7"
              - vulnerability_alerts        = true -> null
                # (35 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

@acouvreur

@acouvreur acceptance tests on this branch?

My feature branch from main

@acouvreur

@acouvreur I'm confused as to what you're saying? This PR is intended to fix the flaky tests, so if you've got a branch from main it will have the issues this PR fixes present.

@acouvreur

@acouvreur I'm confused as to what you're saying? This PR is intended to fix the flaky tests, so if you've got a branch from main it will have the issues this PR fixes present.

I'm sorry about the confusion, I wanted to point out that this issue is still happening and is preventing me from contributing properly.

So it was more something like: "this issue is still relevant and happens to me, can confirm."

I'm just showing support for this PR 😀

@acouvreur

Sorry @acouvreur I thought you'd commented on the PR to fix this (#2501). FYI PR #2476 makes all of the automation tests work correctly.

@stevehipwell

Hey @stevehipwell, could you clarify what kind of churn you are seeing? What does the plan output look like?

@Lekensteyn

@Lekensteyn I covered how to reproduce in the description as well as what I'm seeing. You can also look at my PR to fix it.

Navigation Menu

Repository navigation

[BUG]: The `github_repository` resource churns on `vulnerability_alerts` if not explicitly set #2489

Expected Behavior

Actual Behavior

Terraform Version

Affected Resource(s)

Terraform Configuration Files

Steps to Reproduce

Debug Output

Panic Output

Code of Conduct

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[BUG]: The github_repository resource churns on vulnerability_alerts if not explicitly set #2489

Description

Expected Behavior

Actual Behavior

Terraform Version

Affected Resource(s)

Terraform Configuration Files

Steps to Reproduce

Debug Output

Panic Output

Code of Conduct

Activity

stevehipwell commented on Dec 3, 2024

stevehipwell commented on Dec 4, 2024

acouvreur commented on Feb 11, 2025

stevehipwell commented on Feb 11, 2025

acouvreur commented on Feb 11, 2025

stevehipwell commented on Feb 11, 2025

acouvreur commented on Feb 11, 2025

stevehipwell commented on Feb 11, 2025

Lekensteyn commented on Mar 7, 2025

stevehipwell commented on Mar 7, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[BUG]: The `github_repository` resource churns on `vulnerability_alerts` if not explicitly set #2489