Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves GitHub Actions logging by replacing scattered core.info messages and low-level startGroup/endGroup usage with core.group(...) blocks, making logs more structured and collapsible while preserving existing behavior.
Changes:
- Wrap key steps in
handlePullRequestEventandhandleOtherEventwithcore.group(...)for clearer, scoped logs. - Move grouping responsibility up to callers and remove
core.startGroup/core.endGroupfromgit.getParentSHAs. - Update unit tests to mock
core.groupso grouped callbacks still execute during tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/pull_request_event.test.ts | Mocks core.group to execute grouped callbacks during PR event tests. |
| tests/other_event.test.ts | Imports @actions/core and mocks core.group for grouped logging paths. |
| src/pull_request_event.ts | Converts major log steps (commit, graph, push, cherry-pick flow) into grouped sections. |
| src/other_event.ts | Groups commit, fast-forward attempt, and PR fallback for clearer action logs. |
| src/git.ts | Removes internal grouping from getParentSHAs to avoid nested/low-level log grouping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.