fix: fix default hostname when hosts.yml is empty#203
Merged
Conversation
pinglin
added a commit
that referenced
this pull request
Oct 24, 2023
Because - when `hosts.yml` is empty, the `default_hostname` value in `config.yml` should fallback to the default hostname `api.instill.tech`. - the bug fails `inst auth login` when the user run `inst local deploy` at the very beginning (with a fresh `inst` installed) followed by `inst local undeploy` right away, where the `default_hostname` will be left with `localhost:8080`. - with a fresh `inst` installed, `inst auth login` uses the default hostname `api.instill.tech`. This commit - fix the bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
hosts.ymlis empty, thedefault_hostnamevalue inconfig.ymlshould fallback to the default hostnameapi.instill.tech.inst auth loginwhen the user runinst local deployat the very beginning (with a freshinstinstalled) followed byinst local undeployright away, where thedefault_hostnamewill be left withlocalhost:8080.instinstalled,inst auth loginuses the default hostnameapi.instill.tech.This commit