Skip to content

fix: handle API prefixes#186

Merged
TobiaszCudnik merged 2 commits intomainfrom
tobias/ins-2192-cli-proper-api-prefix-handling
Sep 29, 2023
Merged

fix: handle API prefixes#186
TobiaszCudnik merged 2 commits intomainfrom
tobias/ins-2192-cli-proper-api-prefix-handling

Conversation

@TobiaszCudnik
Copy link
Copy Markdown
Contributor

Because

  • currently, only the /vdp prefix is supported

This commit

  • adds support for model and base, while defaulting to vdp for unprefixed calls

@linear
Copy link
Copy Markdown

linear bot commented Sep 28, 2023

INS-2192 CLI: proper API prefix handling

  • default to /vdp when empty
  • allow vdp|model|base
  • inject the api version automatically

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a9d3b4b) 51.09% compared to head (d509dd4) 51.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   51.09%   51.33%   +0.24%     
==========================================
  Files          54       54              
  Lines        4196     4223      +27     
==========================================
+ Hits         2144     2168      +24     
- Misses       1833     1834       +1     
- Partials      219      221       +2     
Flag Coverage Δ
unittests 51.33% <88.88%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cmd/api/api.go 71.38% <88.88%> (+1.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TobiaszCudnik TobiaszCudnik merged commit aa68440 into main Sep 29, 2023
@TobiaszCudnik TobiaszCudnik deleted the tobias/ins-2192-cli-proper-api-prefix-handling branch September 29, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants