refactor(auth): remove .env file import logic#183
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 51.09% 50.86% -0.24%
==========================================
Files 54 54
Lines 4196 4215 +19
==========================================
Hits 2144 2144
- Misses 1833 1852 +19
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Contributor
|
This PR isnt a |
TobiaszCudnik
force-pushed
the
main
branch
4 times, most recently
from
511098a to
8c90e7c
Compare
pinglin
changed the title
pinglin
force-pushed
the
pinglin/remove-env-for-auth
branch
from
fac8347 to
b7cb03a
Compare
pinglin
force-pushed
the
pinglin/remove-env-for-auth
branch
from
b7cb03a to
826f23a
Compare
pinglin
force-pushed
the
pinglin/remove-env-for-auth
branch
from
51f688b to
2db5038
Compare
Contributor
|
@pinglin This PR causes incorrect initial behavior when theres no config: Default instance logic has been broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
OAuth2 client-credential flow callback to a local machine can use a constant URL
http://localhost:8085client-idandclient-secretfor productionapi.instill.techare injected during build/installation time by:For internal maintenance only - We can still set staging and dev Instill Cloud with the corresponding
client-idandclient-secretthroughThis commit
internal/oauth2auth loginright after installation error