version 0.2.4: move scipy/matplotlib/skimage into sub-func#41
version 0.2.4: move scipy/matplotlib/skimage into sub-func#41yunjunz merged 1 commit intoinsarlab:mainfrom
Conversation
+ move scipy/matplotlib/skimage into the sub-functions, to avoid adding them to the requirements/host in the conda-forge recipe, as the latter is recommended by conda-forge guideline + add release Tag for version 0.2.4
|
@yunjunz where do you see this recommendation? |
Hi @jhkennedy, I was reading from here (https://conda-forge.org/docs/maintainer/adding_pkgs.html#build-host-and-run). My understanding from it is: This is because of the change in I am aware that moving them into the sub-function is not ideal, am happy to hear if you have more elegant solution. |
|
@yunjunz ah gotcha! Generally, the recommendation is to not import your package in I agree it's desirable to provide the version number as a package variable and dynamically generate the version from the git history for dev versions, but you can do that without needing to import the package using tools like I could open a PR for that if you'd like. |
|
That would be great @jhkennedy! And you are also more than welcome to change |
This reverts commit cf2d017.
+ add `pyproject.toml` to simplify `setup.py` + use `setuptools_scm` in `pyproject.toml` and `__init__.py` for the dynamic version number - remove the redundant `src/pysolid/version.py` - this allows the reversion of "move scipy/matplotlib/skimage into sub-func (#41)" (to move the module imports of matplotlib/scipy/skimage back to the top of the script) + add `.github/dependabot.yml` to keep actions up to date + README: fix typo + add explanation of editable install + update pypi workflow to use cibuildwheel for pip install: - rename publish-to-test-pypi.yml to build-and-publish-to-pypi.yml - use fortran build from cibuildwheel (see:pypa/cibuildwheel#404) - skip building wheel for windows as it's not working yet + deps: add the packaging/installation dependencies to requirements.txt and environment.yml: - pip - setuptools - setuptools_scm - wheel Co-authored-by: Zhang Yunjun <[email protected]>
2 participants
move scipy/matplotlib/skimage into the sub-functions, to avoid adding them to the requirements/host in the conda-forge recipe, as the latter is recommended by conda-forge guideline
add release Tag for version 0.2.4