Skip to content

bugfix for manually specified site_list_file in gps.search_gps()#771

Merged
yunjunz merged 3 commits intoinsarlab:mainfrom
kanglcn:main
May 7, 2022
Merged

bugfix for manually specified site_list_file in gps.search_gps()#771
yunjunz merged 3 commits intoinsarlab:mainfrom
kanglcn:main

Conversation

@kanglcn
Copy link
Copy Markdown
Contributor

@kanglcn kanglcn commented May 7, 2022 •
edited by yunjunz
Loading

Description of proposed changes

Fix a bug that site_list_file will not be downloaded when the user specifies the path to it. nisar-solid/ATBD#23 (comment)

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

@kanglcn
fix a bug in gps.search_gps()
f92265f 
Fix a bug that `site_list_file` will not be downloaded when the user specifies the path to it.
@welcome
Copy link
Copy Markdown

welcome bot commented May 7, 2022

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz changed the title fix a bug in gps.search_gps() bugfix for manually specified site_list_file in gps.search_gps() May 7, 2022
@yunjunz yunjunz self-requested a review May 7, 2022 20:49
yunjunz
yunjunz approved these changes May 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @kanglcn!

@yunjunz yunjunz merged commit 8b32b3c into insarlab:main May 7, 2022
@welcome
Copy link
Copy Markdown

welcome bot commented May 7, 2022

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kanglcn @yunjunz