bugfix for timeseries2velocity.py --bootstrap --save-res#733
Merged
Conversation
When running `timeseries2velocity.py` with bootstrapping, we use the function `time_func.estimate_time_func` to repeatedly fit the time series data. This function returns the design matrix, `G`, however when bootstrapping we don't assign the design matrix to a variable, meaning that if we try to save the residual file we get the error `UnboundLocalError: local variable 'G' referenced before assignment` at line 702. If we want to output the residual when bootstrapping, we need to get the full design matrix. I've added a line of code to do this.
yunjunz
changed the title
timeseries2velocity.py --bootstrap --save-res
yunjunz
requested review from
yuankailiu and
yunjunz
and removed request for
yuankailiu
yunjunz
approved these changes
Jan 28, 2022
Member
yunjunz
left a comment
yunjunz
left a comment
There was a problem hiding this comment.
LGTM. Thank you @olliestephenson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
timeseries2velocity.pywith bootstrapping, we use the functiontime_func.estimate_time_functo repeatedly fit the time series data. This function returns the design matrix,G, however when bootstrapping we don't assign the design matrix to a variable, meaning that if we try to save the residual file we get the errorUnboundLocalError: local variable 'G' referenced before assignmentat line 702.Related to #654
Description of proposed changes
If we want to output the residual when bootstrapping, we need to get the full design matrix. I've added a line of code to do this.
Reminders