ifgram_inversion: bugfix for the ionoPhase inversion#667
Merged
yuankailiu merged 2 commits intoinsarlab:mainfrom Sep 22, 2021
Merged
ifgram_inversion: bugfix for the ionoPhase inversion#667yuankailiu merged 2 commits intoinsarlab:mainfrom
yuankailiu merged 2 commits intoinsarlab:mainfrom
Conversation
+ Change obsDatasetName for iono timeseries + allow for ionoPhase inversion + convert iono unit to meter
yunjunz
reviewed
Sep 21, 2021
yunjunz
approved these changes
Sep 22, 2021
Member
There was a problem hiding this comment.
Thank you @yuankailiu for the bug fix.
For the naming, you have a good point, I am not sure which style (w or w/o 'timeseries') to use at the moment. We do should keep the naming of the three output files consistent, either ion.h5, ionTempCoh.h5, ionNumInv.h5 or timeseriesIon.h5, temporalCoherenceIon.h5, numInvIon.h5. Maybe for a future discussion, when we integrate the ionospheric correction to smallbaselineApp.py.
yunjunz
changed the title
Contributor
Author
|
Sounds good. Thank you @yunjunz for the review and approval. I can go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Change obsDatasetName for iono timeseries
allow for ionoPhase inversion
convert iono timeseries unit to meter
Reminders