tropo_pyaps3: check GAM account info in pyaps3/model.cfg file#639
tropo_pyaps3: check GAM account info in pyaps3/model.cfg file#639yunjunz merged 6 commits intoinsarlab:mainfrom
Conversation
|
Something I just noticed now: According to this L116 in tropo_pyaps3.py you only accept ERA5. The PR checks all the tropo models that were in |
|
Thank you @pbrotoisworo. I just cleaned up the For the checking here, either removing the other models or keeping them is good to me. If we keep all of them, it will be good to move this checking to an independent function, and call it here. Below is for your reference: |
|
@yunjunz. I've created a separate function to check the pyaps config and kept the other tropo models to prevent errors if people want to use them in the future. The function will check for default values (e.g |
yunjunz
left a comment
There was a problem hiding this comment.
Looks great. Thank you @pbrotoisworo for addressing this issue!
Description of proposed changes
This addresses the error of missing API config for PyAPS. If the user did not input their API credentials in
model.cfgin thepyaps3directory it raised a vagueZeroDivisionError: float division by zeroerror.This revision will now raise a
ValueErrorwith a more appropriate error message telling users that the API config is missing.Related to #226.
Reminders