asc_desc2horz_vert: bugfix on custom azimuth and refactor#636
asc_desc2horz_vert: bugfix on custom azimuth and refactor#636yunjunz merged 4 commits intoinsarlab:mainfrom
Conversation
The azimuth variable is supplied as part of the command line input, however it's not actually passed to the `get_design_matrix` function where its needed, meaning the command line variable does nothing and the azimuth angle defaults to 90 degrees. I've added code to pass it through to the design matrix function, so now the azimuth angle can be modified via the command line.
|
The bug was introduced in #230. Thank you @olliestephenson for finding it out and fixing it! |
+ use `azimuth` for the direction of interest throughout the script + use `los_az_angle` for the direction of LOS vector throughout the script, and to replace `head_angle` to be consistent with the rest of mintpy + update comments accordingly.
|
I find my notations in the script are not very clear, so I refactor them here. Below is the notebook I used for testing: |
yunjunz
changed the title
|
For anyone who might be interested or concerned, the version before this PR works fine with the default azimuth direction. So I don't expect any impact if you did not specify an azimuth angle in the command line. |
yunjunz
changed the title
|
Hi @olliestephenson, please note that I change the input azimuth angle definition to |
2 participants
The azimuth variable is supplied as part of the command line input, however it's not actually passed to the
get_design_matrixfunction where its needed, meaning the command line variable does nothing and the azimuth angle defaults to 90 degrees. I've added code to pass it through to the design matrix function, so now the azimuth angle can be modified via the command line.