small changes: dem_error, ifgram_inversion, plot_network#587
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom Jun 23, 2021
Merged
small changes: dem_error, ifgram_inversion, plot_network#587yunjunz merged 3 commits intoinsarlab:mainfrom
yunjunz merged 3 commits intoinsarlab:mainfrom
Conversation
yunjunz
reviewed
Jun 23, 2021
yunjunz
reviewed
Jun 23, 2021
yunjunz
reviewed
Jun 23, 2021
2e265ec to
783fe5e
Compare
+ add a cpt file: romanian.cpt; update the colormaps.md doc + dem_error.py: allow for periodic temporal function fitting + ifgram_inversion.py: allow for inverting ionosphere timeseries + plot_network.py: baseline plot with zero-mean perp baseline
yunjunz
approved these changes
Jun 23, 2021
Member
yunjunz
left a comment
There was a problem hiding this comment.
Thank you @yuankailiu. All looks good and helpful.
I agree that we should move the timeseriesResidual file to ts2vel.py. Let's create an independent issue for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
A Romanian-flag colormap is added into the path:
mintpy/data/colormaps/. The colormap goes from red to yellow, to blue. One example here is with the network plot with continuous colormap. It's showing high coherence (blue), intermediate level coherence (yellow), and low coherence (red). I guess this will be useful.The current DEM error correction has polynomial and step functions. Now we can add periodic time functions since the
timeseries2velocity.pycode is much advanced. Maybe we could just move the generation of timeseriesResidual file from dem_error.py to ts2vel.py eventually. But I don't know how to do it right now.ifgram_inversion.py: Now it allows for inverting the time series of the ionosphere correction. The code now can recognize the corresponding head of the filename (i.e., starting with "ion").
plot_network.py: I think it would be good to make the baseline plot with zero-mean perpendicular baselines. So that the entire plot looks centered around zero, rather than systematically shifted upward or downward.
Reminders