Skip to content

small changes: dem_error, ifgram_inversion, plot_network#587

Merged
yunjunz merged 3 commits intoinsarlab:mainfrom
yuankailiu:update
Jun 23, 2021
Merged

small changes: dem_error, ifgram_inversion, plot_network#587
yunjunz merged 3 commits intoinsarlab:mainfrom
yuankailiu:update

Conversation

@yuankailiu
Copy link
Copy Markdown
Contributor

@yuankailiu yuankailiu commented Jun 22, 2021

Description of proposed changes

  1. A Romanian-flag colormap is added into the path: mintpy/data/colormaps/. The colormap goes from red to yellow, to blue. One example here is with the network plot with continuous colormap. It's showing high coherence (blue), intermediate level coherence (yellow), and low coherence (red). I guess this will be useful.

  2. The current DEM error correction has polynomial and step functions. Now we can add periodic time functions since the timeseries2velocity.py code is much advanced. Maybe we could just move the generation of timeseriesResidual file from dem_error.py to ts2vel.py eventually. But I don't know how to do it right now.

  3. ifgram_inversion.py: Now it allows for inverting the time series of the ionosphere correction. The code now can recognize the corresponding head of the filename (i.e., starting with "ion").

  4. plot_network.py: I think it would be good to make the baseline plot with zero-mean perpendicular baselines. So that the entire plot looks centered around zero, rather than systematically shifted upward or downward.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz yunjunz self-requested a review June 23, 2021 00:47
@yuankailiu yuankailiu force-pushed the update branch 2 times, most recently from 2e265ec to 783fe5e Compare June 23, 2021 17:55
+ add a cpt file: romanian.cpt; update the colormaps.md doc

+ dem_error.py: allow for periodic temporal function fitting

+ ifgram_inversion.py: allow for inverting ionosphere timeseries

+ plot_network.py: baseline plot with zero-mean perp baseline
Copy link
Copy Markdown
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yuankailiu. All looks good and helpful.

I agree that we should move the timeseriesResidual file to ts2vel.py. Let's create an independent issue for that.

@yunjunz yunjunz merged commit 570f417 into insarlab:main Jun 23, 2021
@yuankailiu yuankailiu deleted the update branch June 28, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants