ETCM-370: Refine responses validation on block fetcher side #993
Merged
AnastasiiaL merged 1 commit intodevelopfrom May 28, 2021
Merged
ETCM-370: Refine responses validation on block fetcher side #993AnastasiiaL merged 1 commit intodevelopfrom
AnastasiiaL merged 1 commit intodevelopfrom
Conversation
AurelienRichez
approved these changes
May 27, 2021
leo-bogastry
approved these changes
May 28, 2021
Contributor
leo-bogastry
left a comment
There was a problem hiding this comment.
Nice PR description 👍
…blacklisting on that Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
BlockFetcherperforms bunch of validations on received responses but then it doesn't blacklist peer even if the response is clearly invalid.The goal of this PR is to: