ETCM-720: Added tests for mining block on beginning or end of epoch#950
Merged
ETCM-720: Added tests for mining block on beginning or end of epoch#950
Conversation
milenkara
requested review from
bsuieric,
grale88,
leo-bogastry,
robinraju and
ten15bit
bsuieric
approved these changes
Mar 24, 2021
ten15bit
approved these changes
Mar 24, 2021
milenkara
force-pushed
the
ETCM-720-tests-for-mining-in-epoch
branch
4 times, most recently
from
b588fe3 to
76038e8
Compare
milenkara
force-pushed
the
ETCM-720-tests-for-mining-in-epoch
branch
from
76038e8 to
bce338c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests for mining first and last block of an epoch.
Testing
In order to validate my changes, I have temporarily reverted @pbvie's changes and the test were failing when generating the last block of the epoch. With the new changes mining tests are passing.
Additional note: I noticed that in the
build.sbtminer tests (EthashMinerSpec) are excluded. I have changed this during development, but didn't include it in the PR.