[ETCM-685] Improve pivot block selection#949
Merged
Conversation
robinraju
force-pushed
the
ETCM-685-pivot-block-selection
branch
from
d70fdac to
6c00b4e
Compare
robinraju
requested review from
AnastasiiaL,
bsuieric,
dzajkowski,
jvdp,
leo-bogastry and
ten15bit
robinraju
force-pushed
the
ETCM-685-pivot-block-selection
branch
2 times, most recently
from
f867117 to
4292102
Compare
dzajkowski
approved these changes
Mar 25, 2021
robinraju
force-pushed
the
ETCM-685-pivot-block-selection
branch
from
4292102 to
3d7934a
Compare
jvdp
approved these changes
Mar 29, 2021
Contributor
jvdp
left a comment
jvdp
left a comment
There was a problem hiding this comment.
It gets the job done and nothing is standing out but that PivotBlockSelector is pretty smelly and is getting just a bit worse with these additions.
robinraju
force-pushed
the
ETCM-685-pivot-block-selection
branch
from
3d7934a to
efa587c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If Mantis connects with a peer with the best block number bigger than other nodes (the difference bigger than
pivotBlockOffset) it will wait for a minimum number of voters infinitely and never choose pivot block and will never start to sync.Proposed Solution
If a particular pivot block cannot be confirmed,
Important Changes Introduced
PivotBlockSelector.scalaTesting
Unit tests were added.