etcm-678 etcm-660 fix for removing chain after the node restart#940
Merged
etcm-678 etcm-660 fix for removing chain after the node restart#940
Conversation
AnastasiiaL
reviewed
Mar 16, 2021
bsuieric
changed the title
AnastasiiaL
approved these changes
Mar 18, 2021
bsuieric
changed the title
bsuieric
force-pushed
the
bug/ETCM-678-after-node-restart
branch
from
b7f2b32 to
cde6728
Compare
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
reviewed
Mar 24, 2021
| //not reorganising anymore until oldBlock4(not part of the chain anymore), no block/ommer validation when not part of the chain, resolveBranch is returning UnknownBranch | ||
| blockImporter ! BlockFetcher.PickedBlocks(NonEmptyList.fromListUnsafe(List(newComerBlock5WithOldBlock4Parent))) | ||
|
|
||
| Thread.sleep(200) |
Contributor
There was a problem hiding this comment.
that hurts. is there a plan to get rid of Thread.sleep?
Contributor
Author
There was a problem hiding this comment.
eventually is pretty neat :)
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
reviewed
Mar 24, 2021
dzajkowski
approved these changes
Mar 24, 2021
Contributor
dzajkowski
left a comment
dzajkowski
left a comment
There was a problem hiding this comment.
added a few nitpicks but overall looks ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding check validating if the block exists in chain - Using any of getXXXByHash is not always accurate - after restart the best block is often lower than before restart. This change is trying to resolve the branch and checking the existence of the block when trying to import blocks