[ETCM-571] Add metric on the time taken to evaluate a submitted PoW#932
Merged
leo-bogastry merged 1 commit intodevelopfrom Mar 5, 2021
Merged
Conversation
leo-bogastry
force-pushed
the
feature/ETCM-571-eth_submitWork-metric
branch
from
345f994 to
c83021d
Compare
ten15bit
approved these changes
Mar 3, 2021
dzajkowski
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a metric on how long a node takes to evaluate if a solution submitted by a miner is valid (without broadcasting it)
Proposed Solution
A timer metric was added to
EthashBlockGenerator.getPreparedmethodTesting
insomnia_workspace.jsonwas updated to include theeth_submitWorkcall with bogus data. This call can be used to simulate a miner sending the result of the PoW (does not need to be a real one). Several calls over time need to be made. A panel was added to Grafana that allows to see the new metric