Merged
Conversation
jvdp
requested review from
AnastasiiaL,
bsuieric,
dzajkowski,
leo-bogastry,
robinraju and
ten15bit
leo-bogastry
approved these changes
Jan 26, 2021
Contributor
leo-bogastry
left a comment
leo-bogastry
left a comment
There was a problem hiding this comment.
It looks good to me!
bsuieric
approved these changes
Jan 27, 2021
jvdp
force-pushed
the
feature/ETCM-528-block-creation-metrics
branch
from
f99589f to
0469118
Compare
…cs for generateBlock
jvdp
force-pushed
the
feature/ETCM-528-block-creation-metrics
branch
from
0469118 to
56051c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to help improve our understanding of the performance of
eth_getWorkand Mantis' usefulness for coordinating mining pools.The JSON RPC Controller already had instrumentation but without a method label, so I've added this. In addition I added a
ConsensusMetricsobject with timer metrics for the differentgenerateBlockimplementations (with a class label.) I've updated the mantis-dashboard.json file with the new metrics.(Recreated from #902 with a consistent branch name.)