Fix scala==2.13 nix build, cleanup#882
Merged
dmitry-worker merged 19 commits intofeature/ETCM-129-scala-point-13from Jan 11, 2021
Merged
Fix scala==2.13 nix build, cleanup#882dmitry-worker merged 19 commits intofeature/ETCM-129-scala-point-13from
dmitry-worker merged 19 commits intofeature/ETCM-129-scala-point-13from
Conversation
dmitry-worker
approved these changes
Jan 9, 2021
Contributor
dmitry-worker
left a comment
dmitry-worker
left a comment
There was a problem hiding this comment.
Thanks @jonringer! We now have
- no more repo.nix
- no sbtix-related stuff in code
That's awesome! 👍
But there should be a fix for buildkite, cause it tries to follow the old build scenario.
Would you like me to update it or maybe we can manage it together using tmate?
It would be great if one can test buildkite without commiting anything to the repo...
Regarding this PR - I believe I'm not an expert in Nix packaging, so we may require @manveru 's review.
manveru
requested changes
Jan 9, 2021
Contributor
manveru
left a comment
manveru
left a comment
There was a problem hiding this comment.
looks good otherwise, just needs one change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix build with scala 2.13
cc @input-output-hk/mantis-devs