[ETCM-491] Use etc.conf as default config file#880
Conversation
aakoshh
left a comment
There was a problem hiding this comment.
Thanks for taking action on my comment, defaulting to the config on empty seems to make sense, otherwise the user is in control and can do whatever they are trying without interference 👍
I took me a while to understand that this behaviour only applies to the mantis-launcher and not mantis itself. It should be possible to inject a whole script file into the mantis script so ./bin/mantis etc would work the same way, but that's a different issue.
Thank you for the quick response 👍 Regarding the launcher: I made that decision mostly because That said, I also found a technical issue trying to extend the |
Description
Note: This is a continuation of #871. Here I'm addressing the last comment made by @aakoshh in that PR.
If the launcher is executed without arguments, then the default
conf/app.conffile is used which uses etc network. This can lead to confusions because a user would expect to make changes toconf/etc.confand run them using the launcher without arguments.Proposed Solution
If no argument is received, the launcher will select the
conf/etc.conffile as the default configuration. This way the user will see the impacts of changingconf/etc.confwhen running the launcher without arguments.Testing
All validations from #871 should still work. And:
conf/etc.confby setting the network totestnet-internal-nomadbin/mantis-launchertestnet-internal-nomadnetwork