[ETCM-205] Add information about checkpoints in tx history#826
Merged
[ETCM-205] Add information about checkpoints in tx history#826
Conversation
kapke
changed the title
mmrozek
reviewed
Dec 3, 2020
kapke
force-pushed
the
etcm-205-checkpoints-in-history
branch
from
074621e to
df49fda
Compare
kapke
force-pushed
the
etcm-205-checkpoints-in-history
branch
3 times, most recently
from
f8b1e37 to
078d45d
Compare
lemastero
reviewed
Dec 3, 2020
| def apply(keyPair: AsymmetricCipherKeyPair): Address = { | ||
| val pub = crypto.pubKeyFromKeyPair(keyPair) | ||
| Address(crypto.kec256(pub).drop(FirstByteOfAddress)) | ||
| } |
KonradStaniec
approved these changes
Dec 3, 2020
Contributor
KonradStaniec
left a comment
KonradStaniec
left a comment
There was a problem hiding this comment.
Only 1 minor comment
|
|
||
| def apply(keyPair: AsymmetricCipherKeyPair): Address = { | ||
| val pub = crypto.pubKeyFromKeyPair(keyPair) | ||
| Address(crypto.kec256(pub).drop(FirstByteOfAddress)) |
Contributor
There was a problem hiding this comment.
minor: .drop(FirstByteOfAddress) is probably not necessary , as Address bytesting constructor takes only last 20byte also FirstByteOfAddress is weird name for something which drops 12 bytes
kapke
force-pushed
the
etcm-205-checkpoints-in-history
branch
2 times, most recently
from
938ab76 to
7ccad81
Compare
lemastero
approved these changes
Dec 3, 2020
…plex data structures
…tion history rpc method
kapke
force-pushed
the
etcm-205-checkpoints-in-history
branch
from
7ccad81 to
4f9e6e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds information about tx being in checkpointed block or not to
mantis_getAccountTransactions.Also, as it is very useful - in this PR I've added a dependency on diffx - library which highlights the differences in compared data.
Testing
All tests should pass. One can also try to use
qa_generateCheckpointfor adding a checkpoint and checking if transactions from lower blocks are properly marked