[ETCM-395] faucet unit tests#816
Merged
biandratti merged 6 commits intodevelopfrom Nov 27, 2020
Merged
Conversation
mirkoAlic
reviewed
Nov 27, 2020
| shutdownTimeout = 15.seconds | ||
| ) | ||
|
|
||
| val fHandler = TestProbe() |
Contributor
There was a problem hiding this comment.
Suggested change
| val fHandler = TestProbe() | |
| val faucetHandler = TestProbe() |
mirkoAlic
reviewed
Nov 27, 2020
| } | ||
| } | ||
|
|
||
| it should "answer timeout when tried to get status but the Faucet Handler is disable" in new TestSetup { |
Contributor
There was a problem hiding this comment.
Suggested change
| it should "answer timeout when tried to get status but the Faucet Handler is disable" in new TestSetup { | |
| it should "answer internal error when tried to get status but the Faucet Handler is disable" in new TestSetup { |
mirkoAlic
reviewed
Nov 27, 2020
| } | ||
| } | ||
|
|
||
| it should "answer timeout when tried to send funds but the Faucet Handler is disable" in new TestSetup { |
Contributor
There was a problem hiding this comment.
Suggested change
| it should "answer timeout when tried to send funds but the Faucet Handler is disable" in new TestSetup { | |
| it should "answer internal error when tried to send funds but the Faucet Handler is disable" in new TestSetup { |
mirkoAlic
approved these changes
Nov 27, 2020
…tis into ETCM-395-faucet-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit test in class FaucetRpcService.
Fix case when we don't have available the faucetHandler (in the actor system)
Proposed Solution
When we don't have the faucetHandler available, we receive an InternalError.