Conversation
mirkoAlic
reviewed
Nov 26, 2020
| @@ -0,0 +1,1004 @@ | |||
| { | |||
| "allowed-miners": [ | |||
| "006f366775cd73455ee7f208d8dc258ba7c1d48645ef2f4aeef7024652ac10205aed36bfc594e85021acc216762e7ab75f7759a815409f37d05e863651920091", | |||
ntallar
reviewed
Nov 26, 2020
| allowed-miners = [] | ||
| } | ||
|
|
||
| include "chains/testnet-allowed-miners" |
There was a problem hiding this comment.
Should we include the same list of the nomad deployer or will different keys be generated there?
Contributor
Author
There was a problem hiding this comment.
it's a draft. only reason it's open is for hydra to pick it up.
Contributor
Author
There was a problem hiding this comment.
(the previous attempt simply didn't work; hocon documentation isn't super clear)
Contributor
KonradStaniec
left a comment
KonradStaniec
left a comment
There was a problem hiding this comment.
just an general comment: the list of public keys is taken into account only if option
mantis.consensus.protocol is set to restricted-ethash
Contributor
Author
Now you tell me! 😅 |
kaii-zen
force-pushed
the
allowed-miners
branch
2 times, most recently
from
7b0cea4 to
30e70ef
Compare
kaii-zen
changed the title
allowed-miners list to testnet configs
kaii-zen
changed the title
allowed-miners list to testnet configs
added 2 commits
November 27, 2020 10:03
to enable miner whitelist
kaii-zen
force-pushed
the
allowed-miners
branch
from
27686c6 to
3a29713
Compare
ntallar
added
the
BREAKS PROTOCOL
ntallar
approved these changes
Nov 30, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consensus.protocolfor both testnets (inbase-testnet.conf)to
restricted-ethashin order to enable whitelist.Tested that a newly deployed gac-based testnet whose miners are not in the whitelist remains at block 0.