[ETCM-411] Add optional param to generate more keys at once#812
[ETCM-411] Add optional param to generate more keys at once#812KonradStaniec merged 5 commits intodevelopfrom
Conversation
mmrozek
left a comment
mmrozek
left a comment
There was a problem hiding this comment.
Looks good, but what do you think about moving this functionality to CLI?
|
one one side it makes sense, on the other side i know that Shay is using it in that format so it would be probably easier for him to use it that way without any learning curve and changes in tooling |
mmrozek
left a comment
mmrozek
left a comment
There was a problem hiding this comment.
Ok, so maybe create a task to do that in the future. We could handle both methods at the same time. The cli will be more readable for the users
| * ./eckeygen > mantis-datadir/node.key | ||
| * ./eckeygen [n] > mantis-datadir/node.key | ||
| * | ||
| * to generate the private key for the node. Note that only the private key will be read upon Mantis boot, |
There was a problem hiding this comment.
(minor) "[...] Note that only the first private key will be read upon Mantis boot"
There was a problem hiding this comment.
actually it is more general as even if we generate one pair, only the private key is read at boot time and then whole key pair is regenerated based on this key keyPairFromPrvKey(Hex.decode(privHex))
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
abb12b3 to
e513202
Compare
| } | ||
| } | ||
|
|
||
| private val GenerateKeyPairs: Command[String] = |
There was a problem hiding this comment.
Please add a test case to CliCommandsSpec and update README
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
e513202 to
daa32c8
Compare
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
daa32c8 to
074ae4c
Compare
3 participants
Description
Add possibility to generate n keys (ported from other project)