[ETCM-135] Tx history improvements for wallet#808
Merged
Conversation
kapke
added
high priority
kapke
force-pushed
the
etcm-135-tx-history-improvements
branch
from
48587d3 to
b45d65f
Compare
kapke
changed the title
mmrozek
reviewed
Nov 23, 2020
| .concatMap { block => | ||
| val getBlockReceipts = Task { | ||
| blockchain.getReceiptsByHash(block.hash).map(_.toVector).getOrElse(Vector.empty) | ||
| }.memoizeOnSuccess |
Contributor
There was a problem hiding this comment.
memoizeOnSuccess won't work here
Contributor
Author
There was a problem hiding this comment.
it will work on a per-block basis, won't it?
lemastero
reviewed
Nov 23, 2020
|
|
||
| // scalastyle:off number.of.methods | ||
| object EthJsonMethodsImplicits extends JsonMethodsImplicits { | ||
| implicit val transactionResponseJsonEncoder: JsonEncoder[TransactionResponse] = Extraction.decompose(_) |
lemastero
approved these changes
Nov 23, 2020
kapke
force-pushed
the
etcm-135-tx-history-improvements
branch
2 times, most recently
from
8b278fc to
60cfdc2
Compare
kapke
force-pushed
the
etcm-135-tx-history-improvements
branch
from
794d398 to
6c26ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move transaction history method to
mantis_namespace, and add couple of additional informations a requested by Mantis Wallet devs.It's a high priority because it's quite important from wallet perspective.
Testing