ETCM-365: Version info in Hello.clientId#794
Merged
Conversation
aakoshh
force-pushed
the
ETCM-365-hello-client-id
branch
from
c281d52 to
5210423
Compare
aakoshh
force-pushed
the
ETCM-365-hello-client-id
branch
from
5210423 to
9684d23
Compare
ntallar
reviewed
Nov 13, 2020
ntallar
reviewed
Nov 18, 2020
ntallar
approved these changes
Nov 18, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR adds the conventional Ethereum node name in the
WireProtocol.Hello.clientIdfield, for example:mantis/v3.0-cd5ae33/linux-amd64/ubuntu-openjdk64bitservervm-java-11.0.9.The
-Dmantis.client-identityproperty can be used to splice a user identity into it to distinguish our client, perhaps by a ticket number or just belonging to an organisation.I didn't do as an elaborate normalisation as
besuin thePlatformDetector, called fromBesuInfo; seemed like an overkill.