Conversation
mirkoAlic
approved these changes
Nov 11, 2020
Contributor
mirkoAlic
left a comment
mirkoAlic
left a comment
There was a problem hiding this comment.
LGTM! please create a task for future analysis over block queue in order to see how we could start adding tests for this kind of things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue on testnet
Scenario
When importing block 1970:
The above chain didn't have the ommer ancestor, so the validation of them failed with
OmmersAncestorsError. As the above mentioned chain was followed by 3/5 miners they forked irrecoverably.Proposed Solution
Changing
Taking 6 blocks from it resulted in blocks: 1858-1863toTaking the last 6 blocks from it resulted in blocks: 1864-1869Testing
Due to the complexity of testing this scenario and the time requirements for the having the internal testnet running no test was added.